Moe Sync #367
Moe Sync #367
Conversation
Fixes #365 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=244264487
Fixes https://github.com/google/google-java-format/pull/337/files ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=244289776
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=244858188
Adds --google-java-format-jar option that lets the user specify a path to the google-java-format-jar. Fixes #44, #227 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=244863050
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=244880260
….that(foo). (The exact change is slightly different in some cases, like when using custom subjects or check(), but it's always a migration from named(...) to [assert]WithMessage(...).) named(...) is being removed. This CL may slightly modify the failure messages produced, but all the old information will still be present. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=245027655
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
This code has been reviewed and submitted internally. Feel free to discuss on the PR and we can submit follow-up changes as necessary.
Commits:
Give parallelStream() the same treatment as stream()
Fixes #365
d3d2f7a
Remove a branch that is never taken
Fixes https://github.com/google/google-java-format/pull/337/files
6930fca
Refactor max line length handling
35b9cb6
Add support for custom google-java-format jar
Adds --google-java-format-jar option that lets the user specify a path to the google-java-format-jar.
Fixes #44, #227
4099dca
Update to Truth 0.44.
e00def0
Migrate from assertThat(foo).named("foo") to assertWithMessage("foo").that(foo).
(The exact change is slightly different in some cases, like when using custom subjects or check(), but it's always a migration from named(...) to [assert]WithMessage(...).)
named(...) is being removed.
This CL may slightly modify the failure messages produced, but all the old information will still be present.
842cc62