Skip to content

Avoid potential NPE #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Avoid potential NPE #337

wants to merge 1 commit into from

Conversation

Stephan202
Copy link
Contributor

NB: This code is over a year old, so maybe the null branch is never taken?

@cushon
Copy link
Collaborator

cushon commented Apr 18, 2019

maybe the null branch is never taken?

It seems that way, I think we may as well just remove the conditional instead. Thanks for pointing this out.

@Stephan202
Copy link
Contributor Author

The suggested alternative of simply dropping the null branch was merged in #367 (6930fca).

@Stephan202 Stephan202 closed this Apr 29, 2019
@Stephan202 Stephan202 deleted the bugfix/avoid-potential-npe branch April 29, 2019 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stephan202 @cushon @googlebot