-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scheherazade New: Version 4.300 added #8430
Conversation
Taken from the upstream repo https://github.com/silnrsi/font-scheherazade at commit silnrsi/font-scheherazade@7419734.
FontBakery reportfontbakery version: 0.13.0a2 Check results[31] ScheherazadeNew-SemiBold.ttf💥 ERROR Shapes languages in all GF glyphsets.
[code: failed-check] 🔥 FAIL Check if each glyph has the recommended amount of contours.
[code: no-contour]
The following glyphs do not have the recommended number of contours:
[code: contour-count] 🔥 FAIL Ensure smart dropout control is enabled in "prep" table instructions.
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
But: font copyright string has 'https://www.sil.org', font copyright string has 'https://www.sil.org', font copyright string has 'https://www.sil.org', font copyright string has 'https://www.sil.org' and OFL text has 'https://www.sil.org' [code: mismatch]🔥 FAIL Ensure METADATA.pb does not use escaped strings.
🔥 FAIL Name table entries should not contain line-breaks.
🔥 FAIL Copyright notices match canonical pattern in fonts
"Copyright 2020 The Familyname Project Authors (git url)" But instead we have got: "Copyright (c) 1994-2024, SIL Global (https://www.sil.org/), with Reserved Font Names "Scheherazade" and "SIL". This Font Software is licensed under the SIL Open Font License, Version 1.1." [code: bad-notice-format]
"Copyright 2020 The Familyname Project Authors (git url)" But instead we have got: "Copyright (c) 1994-2024, SIL Global (https://www.sil.org/), with Reserved Font Names "Scheherazade" and "SIL". This Font Software is licensed under the SIL Open Font License, Version 1.1." [code: bad-notice-format]🔥 FAIL Check license file has good copyright string.
"copyright (c) 1994-2024, sil global (https://www.sil.org/)," which does not match the expected format, similar to: "Copyright 2022 The Familyname Project Authors (git url)" [code: bad-format]🔥 FAIL Check copyright namerecords match license file.
This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is copied below, and is also available with a FAQ at: https://openfontlicense.org/ SIL OPEN FONT LICENSE Version 1.1 - 26 February 2007PREAMBLE The goals of the Open Font License (OFL) are to stimulate worldwide development of collaborative font projects, to support the font creation efforts of academic and linguistic communities, and to provide a free and open framework in which fonts may be shared and improved in partnership with others. The OFL allows the licensed fonts to be used, studied, modified and redistributed freely as long as they are not sold by themselves. The fonts, including any derivative works, can be bundled, embedded, redistributed and/or sold with any software provided that any reserved names are not used by derivative works. The fonts and derivatives, however, cannot be released under any other type of license. The requirement for fonts to remain under this license does not apply to any document created using the fonts or their derivatives. DEFINITIONS "Font Software" refers to the set of files released by the Copyright Holder(s) under this license and clearly marked as such. This may include source files, build scripts and documentation. "Reserved Font Name" refers to any names specified as such after the copyright statement(s). "Original Version" refers to the collection of Font Software components as distributed by the Copyright Holder(s). "Modified Version" refers to any derivative made by adding to, deleting, or substituting -- in part or in whole -- any of the components of the Original Version, by changing formats or by porting the Font Software to a new environment. "Author" refers to any designer, engineer, programmer, technical writer or other person who contributed to the Font Software. PERMISSION & CONDITIONS Permission is hereby granted, free of charge, to any person obtaining a copy of the Font Software, to use, study, copy, merge, embed, modify, redistribute, and sell modified and unmodified copies of the Font Software, subject to the following conditions:
TERMINATION This license becomes null and void if any of the above conditions are not met. DISCLAIMER THE FONT SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO ANY WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF COPYRIGHT, PATENT, TRADEMARK, OR OTHER RIGHT. IN NO EVENT SHALL THE COPYRIGHT HOLDER BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, INCLUDING ANY GENERAL, SPECIAL, INDIRECT, INCIDENTAL, OR CONSEQUENTIAL DAMAGES, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF THE USE OR INABILITY TO USE THE FONT SOFTWARE OR FROM OTHER DEALINGS IN THE FONT SOFTWARE." Must be changed to "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: https://openfontlicense.org" [code: wrong]🔥 FAIL Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
|
ofl/scheherazadenew/ScheherazadeNew-SemiBold.ttf | |
---|---|
Dehinted Size | 562.3kb |
Hinted Size | 562.3kb |
Increase | -24 bytes |
Change | -0.0 % |
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- loca
- GPOS
- GSUB
- JSTF
[code: optional-tables]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
- ℹ️ INFO
Please consider adding a family.minisite_url entry.
[code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
- ℹ️ INFO
Found a git repo URL: https://github.com/silnrsi/font-scheherazade
[code: url-found]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
- ℹ️ INFO
This font doesn't have an ARTICLE.en_us.html file.
[code: missing-article]
ℹ️ INFO EPAR table present in font?
- ℹ️ INFO
EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818
[code: lacks-EPAR]
[31] ScheherazadeNew-Bold.ttf
💥 ERROR Shapes languages in all GF glyphsets.
- 💥 ERROR
Failed with AttributeError: 'NoneType' object has no attribute 'get'
File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/fontbakery/checkrunner.py", line 213, in _run_check
subresults = list(subresults)
File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/fontbakery/checks/vendorspecific/googlefonts/glyphset.py", line 140, in check_glyphsets_shape_languages
reporter = shaperglot_checker.check(shaperglot_languages[language_code])
File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/shaperglot/checker.py", line 54, in check
for check_object in self.lang.get("shaperglot_checks", []):
[code: failed-check]
🔥 FAIL Check if each glyph has the recommended amount of contours.
- 🔥 FAIL
The following glyphs have no contours even though they were expected to have some:
- Glyph name: uniFFFC Expected: 22
- Glyph name: uniFFFC Expected: 22
[code: no-contour]
⚠️ WARNThis check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.
The following glyphs do not have the recommended number of contours:
- Glyph name: asterisk Contours detected: 8 Expected: 1 or 4
-
Glyph name: uni00AD Contours detected: 1 Expected: 0
-
Glyph name: notequal Contours detected: 3 Expected: 1
-
Glyph name: asterisk Contours detected: 8 Expected: 1 or 4
-
Glyph name: fi Contours detected: 1 Expected: 3
-
Glyph name: notequal Contours detected: 3 Expected: 1
Glyph name: uni00AD Contours detected: 1 Expected: 0
[code: contour-count]
🔥 FAIL Ensure smart dropout control is enabled in "prep" table instructions.
- 🔥 FAIL
The 'prep' table does not contain TrueType instructions enabling smart dropout control. To fix, export the font with autohinting enabled, or run ttfautohint on the font, or run the
gftools fix-nonhinting
script.
[code: lacks-smart-dropout]
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
- 🔥 FAIL
Repository URL is https://github.com/silnrsi/font-scheherazade
But: font copyright string has 'https://www.sil.org', font copyright string has 'https://www.sil.org', font copyright string has 'https://www.sil.org', font copyright string has 'https://www.sil.org' and OFL text has 'https://www.sil.org'
[code: mismatch]🔥 FAIL Ensure METADATA.pb does not use escaped strings.
-
🔥 FAIL
Found escaped chars at 'Copyright (c) 1994-2024, SIL Global (https://www.sil.org/), with Reserved Font Names Scheherazade and SIL.\n\nThis Font Software is licensed under the SIL Open Font License, Version 1.1.'. Please use an unicode string instead.
[code: escaped-strings] -
🔥 FAIL
Found escaped chars at 'Copyright (c) 1994-2024, SIL Global (https://www.sil.org/), with Reserved Font Names Scheherazade and SIL.\n\nThis Font Software is licensed under the SIL Open Font License, Version 1.1.'. Please use an unicode string instead.
[code: escaped-strings] -
🔥 FAIL
Found escaped chars at 'Copyright (c) 1994-2024, SIL Global (https://www.sil.org/), with Reserved Font Names Scheherazade and SIL.\n\nThis Font Software is licensed under the SIL Open Font License, Version 1.1.'. Please use an unicode string instead.
[code: escaped-strings] -
🔥 FAIL
Found escaped chars at 'Copyright (c) 1994-2024, SIL Global (https://www.sil.org/), with Reserved Font Names Scheherazade and SIL.\n\nThis Font Software is licensed under the SIL Open Font License, Version 1.1.'. Please use an unicode string instead.
[code: escaped-strings]
🔥 FAIL Name table entries should not contain line-breaks.
-
🔥 FAIL
Name entry COPYRIGHT_NOTICE on platform WINDOWS contains a line-break.
[code: line-break] -
🔥 FAIL
Name entry LICENSE_DESCRIPTION on platform WINDOWS contains a line-break.
[code: line-break]
🔥 FAIL Copyright notices match canonical pattern in fonts
- 🔥 FAIL
Name Table entry: Copyright notices should match a pattern similar to:
"Copyright 2020 The Familyname Project Authors (git url)"
But instead we have got:
"Copyright (c) 1994-2024, SIL Global (https://www.sil.org/), with Reserved Font Names "Scheherazade" and "SIL".
This Font Software is licensed under the SIL Open Font License, Version 1.1."
[code: bad-notice-format]- 🔥 FAIL
METADATA.pb: Copyright notices should match a pattern similar to:
"Copyright 2020 The Familyname Project Authors (git url)"
But instead we have got:
"Copyright (c) 1994-2024, SIL Global (https://www.sil.org/), with Reserved Font Names "Scheherazade" and "SIL".
This Font Software is licensed under the SIL Open Font License, Version 1.1."
[code: bad-notice-format]🔥 FAIL Check license file has good copyright string.
- 🔥 FAIL
First line in license file is:
"copyright (c) 1994-2024, sil global (https://www.sil.org/),"
which does not match the expected format, similar to:
"Copyright 2022 The Familyname Project Authors (git url)"
[code: bad-format]🔥 FAIL Check copyright namerecords match license file.
- 🔥 FAIL
License file OFL.txt exists but NameID 13 (LICENSE DESCRIPTION) value on platform 3 (WINDOWS) is not specified for that. Value was: "Copyright (c) 1994-2024, SIL Global (https://www.sil.org/), with Reserved Font Names "Scheherazade" and "SIL".
This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is copied below, and is also available with a FAQ at: https://openfontlicense.org/
SIL OPEN FONT LICENSE Version 1.1 - 26 February 2007
PREAMBLE The goals of the Open Font License (OFL) are to stimulate worldwide development of collaborative font projects, to support the font creation efforts of academic and linguistic communities, and to provide a free and open framework in which fonts may be shared and improved in partnership with others.
The OFL allows the licensed fonts to be used, studied, modified and redistributed freely as long as they are not sold by themselves. The fonts, including any derivative works, can be bundled, embedded, redistributed and/or sold with any software provided that any reserved names are not used by derivative works. The fonts and derivatives, however, cannot be released under any other type of license. The requirement for fonts to remain under this license does not apply to any document created using the fonts or their derivatives.
DEFINITIONS "Font Software" refers to the set of files released by the Copyright Holder(s) under this license and clearly marked as such. This may include source files, build scripts and documentation.
"Reserved Font Name" refers to any names specified as such after the copyright statement(s).
"Original Version" refers to the collection of Font Software components as distributed by the Copyright Holder(s).
"Modified Version" refers to any derivative made by adding to, deleting, or substituting -- in part or in whole -- any of the components of the Original Version, by changing formats or by porting the Font Software to a new environment.
"Author" refers to any designer, engineer, programmer, technical writer or other person who contributed to the Font Software.
PERMISSION & CONDITIONS Permission is hereby granted, free of charge, to any person obtaining a copy of the Font Software, to use, study, copy, merge, embed, modify, redistribute, and sell modified and unmodified copies of the Font Software, subject to the following conditions:
-
Neither the Font Software nor any of its individual components, in Original or Modified Versions, may be sold by itself.
-
Original or Modified Versions of the Font Software may be bundled, redistributed and/or sold with any software, provided that each copy contains the above copyright notice and this license. These can be included either as stand-alone text files, human-readable headers or in the appropriate machine-readable metadata fields within text or binary files as long as those fields can be easily viewed by the user.
-
No Modified Version of the Font Software may use the Reserved Font Name(s) unless explicit written permission is granted by the corresponding Copyright Holder. This restriction only applies to the primary font name as presented to the users.
-
The name(s) of the Copyright Holder(s) or the Author(s) of the Font Software shall not be used to promote, endorse or advertise any Modified Version, except to acknowledge the contribution(s) of the Copyright Holder(s) and the Author(s) or with their explicit written permission.
-
The Font Software, modified or unmodified, in part or in whole, must be distributed entirely under this license, and must not be distributed under any other license. The requirement for fonts to remain under this license does not apply to any document created using the Font Software.
TERMINATION This license becomes null and void if any of the above conditions are not met.
DISCLAIMER THE FONT SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO ANY WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF COPYRIGHT, PATENT, TRADEMARK, OR OTHER RIGHT. IN NO EVENT SHALL THE COPYRIGHT HOLDER BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, INCLUDING ANY GENERAL, SPECIAL, INDIRECT, INCIDENTAL, OR CONSEQUENTIAL DAMAGES, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF THE USE OR INABILITY TO USE THE FONT SOFTWARE OR FROM OTHER DEALINGS IN THE FONT SOFTWARE." Must be changed to "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: https://openfontlicense.org"
[code: wrong]🔥 FAIL Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- 🔥 FAIL
Font is missing the 'gasp' table. Try exporting the font with autohinting enabled.
If you are dealing with an unhinted font, it can be fixed by running the fonts through the command 'gftools fix-nonhinting'
GFTools is available at https://pypi.org/project/gftools/
[code: lacks-gasp]
⚠️ WARN Are there caret positions declared for every ligature?
⚠️ WARNThis font lacks caret position values for ligature glyphs on its GDEF table.
[code: lacks-caret-pos]
⚠️ WARN Is there kerning info for non-ligated sequences?
⚠️ WARNGPOS table lacks kerning info for the following non-ligated sequences:
- uni034F + uni064D
- uni034F + uni0650
- uni034F + uni0651
- uni0644.init + uni0627.fina
- uni0644.init + uni0671.fina
- uni0644.init + uni0672.fina
- uni0644.init + uni0673.fina
- uni0644.init + uni0773.fina
- uni0644.init + uni0774.fina
- uni0644.init + uni0870.fina
- 134 more.
Use -F or --full-lists to disable shortening of long lists.
[code: lacks-kern-info]⚠️ WARN Check math signs have the same width.
⚠️ WARNThe most common width is 1782 among a set of 6 math glyphs.
The following math glyphs have a different width, though:
Width = 1165: plus
Width = 1123: equal
Width = 1752: logicalnot
Width = 1274: multiply
Width = 1327: minus
Width = 1549: approxequal
Width = 1189: notequal
[code: width-outliers]⚠️ WARN Does the font contain a soft hyphen?
⚠️ WARNThis font has a 'Soft Hyphen' character.
[code: softhyphen]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
⚠️ WARNFamily metadata at ofl/scheherazadenew does not have an article.
[code: lacks-article]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
⚠️ WARNThe following codepoints supported by the font are not covered by
any subsets defined in the font's metadata file, and will never
be served. You can solve this by either manually adding additional
subset declarations to METADATA.pb, or by editing the glyphset
definitions.
- U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
- U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
- U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
- U+034F COMBINING GRAPHEME JOINER: not included in any glyphset definition
- U+03C0 GREEK SMALL LETTER PI: try adding one of: yi, greek, math
- U+08E2 ARABIC DISPUTED END OF AYAH: not included in any glyphset definition
- U+2000 EN QUAD: try adding symbols2
- U+2001 EM QUAD: try adding symbols2
- U+2003 EM SPACE: try adding nushu
- U+2004 THREE-PER-EM SPACE: try adding symbols2 67 more.
Use -F or --full-lists to disable shortening of long lists.
Or you can add the above codepoints to one of the subsets supported by the font: arabic
, latin
, latin-ext
, menu
⚠️ WARN On a family update, the DESCRIPTION.en_us.html file should ideally also be updated.
⚠️ WARNThe DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
Please consider mentioning note-worthy improvements made to the family recently.
[code: description-not-updated]
⚠️ WARN Check OFL body text is correct.
⚠️ WARNThe OFL.txt body text is incorrect. Please use https://github.com/googlefonts/Unified-Font-Repository/blob/main/OFL.txt as a template. You should only modify the first line.
Lines changed:
+ with Reserved Font Names "Scheherazade" and "SIL".\n
- This Font Software is licensed under the SIL Open Font License, Version 1.1.\n
+ This Font Software is licensed under the SIL Open Font License, Version 1.1,\n
- https://openfontlicense.org\n
+ https://openfontlicense.org/\n
- -----------------------------------------------------------\n
+ ----------------------------------------------------\n
- -----------------------------------------------------------\n
+ ----------------------------------------------------\n
[code: incorrect-ofl-body-text]⚠️ WARN Do any segments have colinear vectors?
⚠️ WARNThe following glyphs have colinear vectors:
* fi (U+FB01): L<<410.0,828.0>--<911.0,828.0>> -> L<<911.0,828.0>--<971.0,828.0>>
* fi (U+FB01): L<<911.0,828.0>--<971.0,828.0>> -> L<<971.0,828.0>--<1018.0,828.0>>
* fl (U+FB02): L<<794.0,1259.0>--<968.0,1259.0>> -> L<<968.0,1259.0>--<1018.0,1259.0>>
* u10EFC (U+10EFC): L<<1002.0,1003.0>--<947.0,938.0>> -> L<<947.0,938.0>--<520.0,327.0>>
* uni0622 (U+0622): L<<295.0,1350.0>--<295.0,1248.0>> -> L<<295.0,1248.0>--<384.0,359.0>>
* uni0622.small: L<<294.0,1350.0>--<294.0,1248.0>> -> L<<294.0,1248.0>--<383.0,359.0>>
* uni0623 (U+0623): L<<295.0,1350.0>--<295.0,1248.0>> -> L<<295.0,1248.0>--<384.0,359.0>>
* uni0625 (U+0625): L<<295.0,1350.0>--<295.0,1248.0>> -> L<<295.0,1248.0>--<384.0,359.0>>
* uni0670.large: L<<729.0,1485.0>--<729.0,1391.0>> -> L<<729.0,1391.0>--<787.0,800.0>>
* uni0671 (U+0671): L<<295.0,1350.0>--<295.0,1248.0>> -> L<<295.0,1248.0>--<384.0,359.0>>
* 9 more.
Use -F or --full-lists to disable shortening of long lists.
[code: found-colinear-vectors]⚠️ WARN Check the direction of the outermost contour in each glyph
⚠️ WARNThe following glyphs have a counter-clockwise outer contour:
* uni089C (U+089C) has a counter-clockwise outer contour
* uni08D1 (U+08D1) has a counter-clockwise outer contour
* uni08D2 (U+08D2) has a counter-clockwise outer contour
* uni08E5 (U+08E5) has a counter-clockwise outer contour
* uni08E8 (U+08E8) has a counter-clockwise outer contour
* uni08E8 (U+08E8) has a counter-clockwise outer contour
* uniFD4B (U+FD4B) has a counter-clockwise outer contour
* uniFD4B (U+FD4B) has a counter-clockwise outer contour
[code: ccw-outer-contour]
⚠️ WARN Do outlines contain any jaggy segments?
⚠️ WARNThe following glyphs have jaggy segments:
* _lamar.medi.preAlef: B<<454.0,495.0>-<444.0,567.0>-<432.0,665.0>>/B<<432.0,665.0>-<419.0,523.0>-<386.5,388.5>> = 12.211864582383015
* uni0644.fina: B<<1079.5,50.0>-<1017.0,100.0>-<980.0,236.0>>/B<<980.0,236.0>-<1003.0,44.0>-<1003.0,-146.0>> = 8.388458881822256
* uni06440627.fina: B<<1145.0,495.0>-<1135.0,567.0>-<1123.0,665.0>>/B<<1123.0,665.0>-<1110.0,523.0>-<1077.5,388.5>> = 12.211864582383015
* uni06440671.fina: B<<1146.0,495.0>-<1136.0,567.0>-<1124.0,665.0>>/B<<1124.0,665.0>-<1111.0,523.0>-<1078.5,388.5>> = 12.211864582383015
* uni06440672.fina: B<<1145.0,495.0>-<1135.0,567.0>-<1123.0,665.0>>/B<<1123.0,665.0>-<1110.0,523.0>-<1077.5,388.5>> = 12.211864582383015
* uni06440673.fina: B<<1145.0,495.0>-<1135.0,567.0>-<1123.0,665.0>>/B<<1123.0,665.0>-<1110.0,523.0>-<1077.5,388.5>> = 12.211864582383015
* uni06440773.fina: B<<1145.0,495.0>-<1135.0,567.0>-<1123.0,665.0>>/B<<1123.0,665.0>-<1110.0,523.0>-<1077.5,388.5>> = 12.211864582383015
* uni06440774.fina: B<<1145.0,495.0>-<1135.0,567.0>-<1123.0,665.0>>/B<<1123.0,665.0>-<1110.0,523.0>-<1077.5,388.5>> = 12.211864582383015
* uni06440870.fina: B<<1145.0,495.0>-<1135.0,567.0>-<1123.0,665.0>>/B<<1123.0,665.0>-<1110.0,523.0>-<1077.5,388.5>> = 12.211864582383015
* uni06440871.fina: B<<1145.0,495.0>-<1135.0,567.0>-<1123.0,665.0>>/B<<1123.0,665.0>-<1110.0,523.0>-<1077.5,388.5>> = 12.211864582383015
* 91 more.
Use -F or --full-lists to disable shortening of long lists.
[code: found-jaggy-segments]⚠️ WARN Do outlines contain any semi-vertical or semi-horizontal lines?
⚠️ WARNThe following glyphs have semi-vertical/semi-horizontal lines:
* uni0890 (U+0890): L<<692.0,1421.0>--<1174.0,1423.0>>
* uni0890.2: L<<692.0,1421.0>--<1174.0,1423.0>>
* uni0890.3: L<<966.0,1421.0>--<1448.0,1423.0>>
* uni0890.4: L<<1286.0,1421.0>--<1768.0,1423.0>>
* uni0891 (U+0891): L<<642.0,1423.0>--<1124.0,1421.0>>
* uni0891.2: L<<642.0,1423.0>--<1124.0,1421.0>>
* uni0891.3: L<<868.0,1423.0>--<1350.0,1421.0>>
* uni0891.4: L<<1188.0,1423.0>--<1670.0,1421.0>>
* uniFD4E (U+FD4E): L<<1347.0,799.0>--<1505.0,798.0>>
* uniFDFE (U+FDFE): L<<1262.0,729.0>--<1420.0,728.0>>
[code: found-semi-vertical]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
⚠️ WARNThis font file does not have a 'meta' table.
[code: lacks-meta-table]
ℹ️ INFO Show hinting filesize impact.
- ℹ️ INFO
Hinting filesize impact:
ofl/scheherazadenew/ScheherazadeNew-Bold.ttf | |
---|---|
Dehinted Size | 565.1kb |
Hinted Size | 565.1kb |
Increase | -24 bytes |
Change | -0.0 % |
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- loca
- GPOS
- GSUB
- JSTF
[code: optional-tables]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
- ℹ️ INFO
Please consider adding a family.minisite_url entry.
[code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
- ℹ️ INFO
Found a git repo URL: https://github.com/silnrsi/font-scheherazade
[code: url-found]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
- ℹ️ INFO
This font doesn't have an ARTICLE.en_us.html file.
[code: missing-article]
ℹ️ INFO EPAR table present in font?
- ℹ️ INFO
EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818
[code: lacks-EPAR]
[31] ScheherazadeNew-Medium.ttf
💥 ERROR Shapes languages in all GF glyphsets.
- 💥 ERROR
Failed with AttributeError: 'NoneType' object has no attribute 'get'
File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/fontbakery/checkrunner.py", line 213, in _run_check
subresults = list(subresults)
File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/fontbakery/checks/vendorspecific/googlefonts/glyphset.py", line 140, in check_glyphsets_shape_languages
reporter = shaperglot_checker.check(shaperglot_languages[language_code])
File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/shaperglot/checker.py", line 54, in check
for check_object in self.lang.get("shaperglot_checks", []):
[code: failed-check]
🔥 FAIL Check if each glyph has the recommended amount of contours.
- 🔥 FAIL
The following glyphs have no contours even though they were expected to have some:
- Glyph name: uniFFFC Expected: 22
- Glyph name: uniFFFC Expected: 22
[code: no-contour]
⚠️ WARNThis check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.
The following glyphs do not have the recommended number of contours:
- Glyph name: asterisk Contours detected: 8 Expected: 1 or 4
-
Glyph name: uni00AD Contours detected: 1 Expected: 0
-
Glyph name: notequal Contours detected: 3 Expected: 1
-
Glyph name: asterisk Contours detected: 8 Expected: 1 or 4
-
Glyph name: fi Contours detected: 1 Expected: 3
-
Glyph name: notequal Contours detected: 3 Expected: 1
Glyph name: uni00AD Contours detected: 1 Expected: 0
[code: contour-count]
🔥 FAIL Ensure smart dropout control is enabled in "prep" table instructions.
- 🔥 FAIL
The 'prep' table does not contain TrueType instructions enabling smart dropout control. To fix, export the font with autohinting enabled, or run ttfautohint on the font, or run the
gftools fix-nonhinting
script.
[code: lacks-smart-dropout]
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
- 🔥 FAIL
Repository URL is https://github.com/silnrsi/font-scheherazade
But: font copyright string has 'https://www.sil.org', font copyright string has 'https://www.sil.org', font copyright string has 'https://www.sil.org', font copyright string has 'https://www.sil.org' and OFL text has 'https://www.sil.org'
[code: mismatch]🔥 FAIL Ensure METADATA.pb does not use escaped strings.
-
🔥 FAIL
Found escaped chars at 'Copyright (c) 1994-2024, SIL Global (https://www.sil.org/), with Reserved Font Names Scheherazade and SIL.\n\nThis Font Software is licensed under the SIL Open Font License, Version 1.1.'. Please use an unicode string instead.
[code: escaped-strings] -
🔥 FAIL
Found escaped chars at 'Copyright (c) 1994-2024, SIL Global (https://www.sil.org/), with Reserved Font Names Scheherazade and SIL.\n\nThis Font Software is licensed under the SIL Open Font License, Version 1.1.'. Please use an unicode string instead.
[code: escaped-strings] -
🔥 FAIL
Found escaped chars at 'Copyright (c) 1994-2024, SIL Global (https://www.sil.org/), with Reserved Font Names Scheherazade and SIL.\n\nThis Font Software is licensed under the SIL Open Font License, Version 1.1.'. Please use an unicode string instead.
[code: escaped-strings] -
🔥 FAIL
Found escaped chars at 'Copyright (c) 1994-2024, SIL Global (https://www.sil.org/), with Reserved Font Names Scheherazade and SIL.\n\nThis Font Software is licensed under the SIL Open Font License, Version 1.1.'. Please use an unicode string instead.
[code: escaped-strings]
🔥 FAIL Name table entries should not contain line-breaks.
-
🔥 FAIL
Name entry COPYRIGHT_NOTICE on platform WINDOWS contains a line-break.
[code: line-break] -
🔥 FAIL
Name entry LICENSE_DESCRIPTION on platform WINDOWS contains a line-break.
[code: line-break]
🔥 FAIL Copyright notices match canonical pattern in fonts
- 🔥 FAIL
Name Table entry: Copyright notices should match a pattern similar to:
"Copyright 2020 The Familyname Project Authors (git url)"
But instead we have got:
"Copyright (c) 1994-2024, SIL Global (https://www.sil.org/), with Reserved Font Names "Scheherazade" and "SIL".
This Font Software is licensed under the SIL Open Font License, Version 1.1."
[code: bad-notice-format]- 🔥 FAIL
METADATA.pb: Copyright notices should match a pattern similar to:
"Copyright 2020 The Familyname Project Authors (git url)"
But instead we have got:
"Copyright (c) 1994-2024, SIL Global (https://www.sil.org/), with Reserved Font Names "Scheherazade" and "SIL".
This Font Software is licensed under the SIL Open Font License, Version 1.1."
[code: bad-notice-format]🔥 FAIL Check license file has good copyright string.
- 🔥 FAIL
First line in license file is:
"copyright (c) 1994-2024, sil global (https://www.sil.org/),"
which does not match the expected format, similar to:
"Copyright 2022 The Familyname Project Authors (git url)"
[code: bad-format]🔥 FAIL Check copyright namerecords match license file.
- 🔥 FAIL
License file OFL.txt exists but NameID 13 (LICENSE DESCRIPTION) value on platform 3 (WINDOWS) is not specified for that. Value was: "Copyright (c) 1994-2024, SIL Global (https://www.sil.org/), with Reserved Font Names "Scheherazade" and "SIL".
This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is copied below, and is also available with a FAQ at: https://openfontlicense.org/
SIL OPEN FONT LICENSE Version 1.1 - 26 February 2007
PREAMBLE The goals of the Open Font License (OFL) are to stimulate worldwide development of collaborative font projects, to support the font creation efforts of academic and linguistic communities, and to provide a free and open framework in which fonts may be shared and improved in partnership with others.
The OFL allows the licensed fonts to be used, studied, modified and redistributed freely as long as they are not sold by themselves. The fonts, including any derivative works, can be bundled, embedded, redistributed and/or sold with any software provided that any reserved names are not used by derivative works. The fonts and derivatives, however, cannot be released under any other type of license. The requirement for fonts to remain under this license does not apply to any document created using the fonts or their derivatives.
DEFINITIONS "Font Software" refers to the set of files released by the Copyright Holder(s) under this license and clearly marked as such. This may include source files, build scripts and documentation.
"Reserved Font Name" refers to any names specified as such after the copyright statement(s).
"Original Version" refers to the collection of Font Software components as distributed by the Copyright Holder(s).
"Modified Version" refers to any derivative made by adding to, deleting, or substituting -- in part or in whole -- any of the components of the Original Version, by changing formats or by porting the Font Software to a new environment.
"Author" refers to any designer, engineer, programmer, technical writer or other person who contributed to the Font Software.
PERMISSION & CONDITIONS Permission is hereby granted, free of charge, to any person obtaining a copy of the Font Software, to use, study, copy, merge, embed, modify, redistribute, and sell modified and unmodified copies of the Font Software, subject to the following conditions:
-
Neither the Font Software nor any of its individual components, in Original or Modified Versions, may be sold by itself.
-
Original or Modified Versions of the Font Software may be bundled, redistributed and/or sold with any software, provided that each copy contains the above copyright notice and this license. These can be included either as stand-alone text files, human-readable headers or in the appropriate machine-readable metadata fields within text or binary files as long as those fields can be easily viewed by the user.
-
No Modified Version of the Font Software may use the Reserved Font Name(s) unless explicit written permission is granted by the corresponding Copyright Holder. This restriction only applies to the primary font name as presented to the users.
-
The name(s) of the Copyright Holder(s) or the Author(s) of the Font Software shall not be used to promote, endorse or advertise any Modified Version, except to acknowledge the contribution(s) of the Copyright Holder(s) and the Author(s) or with their explicit written permission.
-
The Font Software, modified or unmodified, in part or in whole, must be distributed entirely under this license, and must not be distributed under any other license. The requirement for fonts to remain under this license does not apply to any document created using the Font Software.
TERMINATION This license becomes null and void if any of the above conditions are not met.
DISCLAIMER THE FONT SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO ANY WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF COPYRIGHT, PATENT, TRADEMARK, OR OTHER RIGHT. IN NO EVENT SHALL THE COPYRIGHT HOLDER BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, INCLUDING ANY GENERAL, SPECIAL, INDIRECT, INCIDENTAL, OR CONSEQUENTIAL DAMAGES, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF THE USE OR INABILITY TO USE THE FONT SOFTWARE OR FROM OTHER DEALINGS IN THE FONT SOFTWARE." Must be changed to "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: https://openfontlicense.org"
[code: wrong]🔥 FAIL Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- 🔥 FAIL
Font is missing the 'gasp' table. Try exporting the font with autohinting enabled.
If you are dealing with an unhinted font, it can be fixed by running the fonts through the command 'gftools fix-nonhinting'
GFTools is available at https://pypi.org/project/gftools/
[code: lacks-gasp]
⚠️ WARN Are there caret positions declared for every ligature?
⚠️ WARNThis font lacks caret position values for ligature glyphs on its GDEF table.
[code: lacks-caret-pos]
⚠️ WARN Is there kerning info for non-ligated sequences?
⚠️ WARNGPOS table lacks kerning info for the following non-ligated sequences:
- uni034F + uni064D
- uni034F + uni0650
- uni034F + uni0651
- uni0644.init + uni0627.fina
- uni0644.init + uni0671.fina
- uni0644.init + uni0672.fina
- uni0644.init + uni0673.fina
- uni0644.init + uni0773.fina
- uni0644.init + uni0774.fina
- uni0644.init + uni0870.fina
- 134 more.
Use -F or --full-lists to disable shortening of long lists.
[code: lacks-kern-info]⚠️ WARN Check math signs have the same width.
⚠️ WARNThe most common width is 1782 among a set of 6 math glyphs.
The following math glyphs have a different width, though:
Width = 1120: plus
Width = 1122: equal
Width = 1752: logicalnot
Width = 1157: multiply
Width = 1327: minus
Width = 1549: approxequal
Width = 1189: notequal
[code: width-outliers]⚠️ WARN Does the font contain a soft hyphen?
⚠️ WARNThis font has a 'Soft Hyphen' character.
[code: softhyphen]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
⚠️ WARNFamily metadata at ofl/scheherazadenew does not have an article.
[code: lacks-article]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
⚠️ WARNThe following codepoints supported by the font are not covered by
any subsets defined in the font's metadata file, and will never
be served. You can solve this by either manually adding additional
subset declarations to METADATA.pb, or by editing the glyphset
definitions.
- U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
- U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
- U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
- U+034F COMBINING GRAPHEME JOINER: not included in any glyphset definition
- U+03C0 GREEK SMALL LETTER PI: try adding one of: yi, greek, math
- U+08E2 ARABIC DISPUTED END OF AYAH: not included in any glyphset definition
- U+2000 EN QUAD: try adding symbols2
- U+2001 EM QUAD: try adding symbols2
- U+2003 EM SPACE: try adding nushu
- U+2004 THREE-PER-EM SPACE: try adding symbols2 67 more.
Use -F or --full-lists to disable shortening of long lists.
Or you can add the above codepoints to one of the subsets supported by the font: arabic
, latin
, latin-ext
, menu
⚠️ WARN On a family update, the DESCRIPTION.en_us.html file should ideally also be updated.
⚠️ WARNThe DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
Please consider mentioning note-worthy improvements made to the family recently.
[code: description-not-updated]
⚠️ WARN Check OFL body text is correct.
⚠️ WARNThe OFL.txt body text is incorrect. Please use https://github.com/googlefonts/Unified-Font-Repository/blob/main/OFL.txt as a template. You should only modify the first line.
Lines changed:
+ with Reserved Font Names "Scheherazade" and "SIL".\n
- This Font Software is licensed under the SIL Open Font License, Version 1.1.\n
+ This Font Software is licensed under the SIL Open Font License, Version 1.1,\n
- https://openfontlicense.org\n
+ https://openfontlicense.org/\n
- -----------------------------------------------------------\n
+ ----------------------------------------------------\n
- -----------------------------------------------------------\n
+ ----------------------------------------------------\n
[code: incorrect-ofl-body-text]⚠️ WARN Do any segments have colinear vectors?
⚠️ WARNThe following glyphs have colinear vectors:
* uni0670 (U+0670): L<<294.0,1527.0>--<294.0,1462.0>> -> L<<294.0,1462.0>--<319.0,1205.0>>
* uni0670.large: L<<652.0,1472.0>--<652.0,1396.0>> -> L<<652.0,1396.0>--<710.0,758.0>>
* uniFD42.smpl: L<<2505.0,1464.0>--<2505.0,1404.0>> -> L<<2505.0,1404.0>--<2568.0,751.0>>
* uniFD43.smpl: L<<2671.0,1747.0>--<2671.0,1686.0>> -> L<<2671.0,1686.0>--<2734.0,1030.0>>
* uniFD44.smpl: L<<2908.0,1758.0>--<2908.0,1697.0>> -> L<<2908.0,1697.0>--<2971.0,1041.0>>
* uniFD4C.smpl: L<<1239.0,1595.0>--<1239.0,1539.0>> -> L<<1239.0,1539.0>--<1295.0,948.0>>
* uniFDFE (U+FDFE): L<<905.0,1716.0>--<905.0,1670.0>> -> L<<905.0,1670.0>--<923.0,1487.0>>
[code: found-colinear-vectors]
⚠️ WARN Check the direction of the outermost contour in each glyph
⚠️ WARNThe following glyphs have a counter-clockwise outer contour:
* uni089C (U+089C) has a counter-clockwise outer contour
* uni08D1 (U+08D1) has a counter-clockwise outer contour
* uni08D2 (U+08D2) has a counter-clockwise outer contour
* uni08E5 (U+08E5) has a counter-clockwise outer contour
* uni08E8 (U+08E8) has a counter-clockwise outer contour
* uni08E8 (U+08E8) has a counter-clockwise outer contour
* uniFD42.smpl has a counter-clockwise outer contour
* uniFD4B (U+FD4B) has a counter-clockwise outer contour
* uniFD4B (U+FD4B) has a counter-clockwise outer contour
[code: ccw-outer-contour]
⚠️ WARN Do outlines contain any jaggy segments?
⚠️ WARNThe following glyphs have jaggy segments:
* uniFD47.smpl: B<<1996.5,1334.5>-<1995.0,1374.0>-<2001.0,1395.0>>/B<<2001.0,1395.0>-<1998.0,1383.0>-<2000.0,1356.5>> = 1.9091524329961989
* uniFD4A (U+FD4A): B<<1116.5,563.5>-<1102.0,649.0>-<1088.0,732.0>>/L<<1088.0,732.0>--<1115.0,668.0>> = 13.299437305534832
* uniFD4C (U+FD4C): L<<482.0,-200.0>--<562.0,-79.0>>/B<<562.0,-79.0>-<556.0,-90.0>-<573.5,-107.0>> = 4.860504608680503
* uniFD4E (U+FD4E): B<<1060.0,1201.5>-<1057.0,1258.0>-<1057.0,1285.0>>/B<<1057.0,1285.0>-<1059.0,1259.0>-<1069.0,1212.5>> = 4.398705354995508
* uniFDCF (U+FDCF): B<<1267.5,1059.0>-<1257.0,1128.0>-<1249.0,1218.0>>/B<<1249.0,1218.0>-<1234.0,1043.0>-<1203.0,913.0>> = 9.978700313802351
* uniFDFA (U+FDFA): L<<1652.0,-49.0>--<1682.0,-24.0>>/B<<1682.0,-24.0>-<1602.0,-116.0>-<1517.5,-156.0>> = 9.185342006164557
* uniFDFB (U+FDFB): B<<1239.5,539.5>-<1225.0,635.0>-<1213.0,730.0>>/B<<1213.0,730.0>-<1187.0,510.0>-<1139.5,394.5>> = 13.93928973631456
* uniFDFD (U+FDFD): L<<4364.0,112.0>--<4433.0,233.0>>/B<<4433.0,233.0>-<4429.0,224.0>-<4448.0,208.0>> = 5.731372051331853
* uniFDFD (U+FDFD): L<<459.0,281.0>--<527.0,403.0>>/B<<527.0,403.0>-<523.0,392.0>-<542.5,376.5>> = 9.151185675326188
* uniFDFD.smpl: L<<4810.0,155.0>--<4879.0,277.0>>/B<<4879.0,277.0>-<4874.0,266.0>-<4893.0,250.5>> = 5.047407022753609
[code: found-jaggy-segments]
⚠️ WARN Do outlines contain any semi-vertical or semi-horizontal lines?
⚠️ WARNThe following glyphs have semi-vertical/semi-horizontal lines:
* uni0890 (U+0890): L<<699.0,1421.0>--<1221.0,1423.0>>
* uni0890.2: L<<699.0,1421.0>--<1221.0,1423.0>>
* uni0890.3: L<<957.0,1421.0>--<1479.0,1423.0>>
* uni0890.4: L<<1211.0,1421.0>--<1733.0,1423.0>>
* uni0891 (U+0891): L<<595.0,1423.0>--<1117.0,1421.0>>
* uni0891.2: L<<595.0,1423.0>--<1117.0,1421.0>>
* uni0891.3: L<<837.0,1423.0>--<1359.0,1421.0>>
* uni0891.4: L<<1090.0,1423.0>--<1612.0,1421.0>>
[code: found-semi-vertical]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
⚠️ WARNThis font file does not have a 'meta' table.
[code: lacks-meta-table]
ℹ️ INFO Show hinting filesize impact.
- ℹ️ INFO
Hinting filesize impact:
ofl/scheherazadenew/ScheherazadeNew-Medium.ttf | |
---|---|
Dehinted Size | 555.2kb |
Hinted Size | 555.2kb |
Increase | -24 bytes |
Change | -0.0 % |
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- loca
- GPOS
- GSUB
- JSTF
[code: optional-tables]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
- ℹ️ INFO
Please consider adding a family.minisite_url entry.
[code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
- ℹ️ INFO
Found a git repo URL: https://github.com/silnrsi/font-scheherazade
[code: url-found]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
- ℹ️ INFO
This font doesn't have an ARTICLE.en_us.html file.
[code: missing-article]
ℹ️ INFO EPAR table present in font?
- ℹ️ INFO
EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818
[code: lacks-EPAR]
[33] ScheherazadeNew-Regular.ttf
💥 ERROR Shapes languages in all GF glyphsets.
- 💥 ERROR
Failed with AttributeError: 'NoneType' object has no attribute 'get'
File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/fontbakery/checkrunner.py", line 213, in _run_check
subresults = list(subresults)
File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/fontbakery/checks/vendorspecific/googlefonts/glyphset.py", line 140, in check_glyphsets_shape_languages
reporter = shaperglot_checker.check(shaperglot_languages[language_code])
File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/shaperglot/checker.py", line 54, in check
for check_object in self.lang.get("shaperglot_checks", []):
[code: failed-check]
🔥 FAIL Check if each glyph has the recommended amount of contours.
- 🔥 FAIL
The following glyphs have no contours even though they were expected to have some:
- Glyph name: uniFFFC Expected: 22
- Glyph name: uniFFFC Expected: 22
[code: no-contour]
⚠️ WARNThis check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.
The following glyphs do not have the recommended number of contours:
- Glyph name: asterisk Contours detected: 8 Expected: 1 or 4
-
Glyph name: uni00AD Contours detected: 1 Expected: 0
-
Glyph name: notequal Contours detected: 3 Expected: 1
-
Glyph name: asterisk Contours detected: 8 Expected: 1 or 4
-
Glyph name: fi Contours detected: 1 Expected: 3
-
Glyph name: notequal Contours detected: 3 Expected: 1
Glyph name: uni00AD Contours detected: 1 Expected: 0
[code: contour-count]
🔥 FAIL Ensure smart dropout control is enabled in "prep" table instructions.
- 🔥 FAIL
The 'prep' table does not contain TrueType instructions enabling smart dropout control. To fix, export the font with autohinting enabled, or run ttfautohint on the font, or run the
gftools fix-nonhinting
script.
[code: lacks-smart-dropout]
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
- 🔥 FAIL
Repository URL is https://github.com/silnrsi/font-scheherazade
But: font copyright string has 'https://www.sil.org', font copyright string has 'https://www.sil.org', font copyright string has 'https://www.sil.org', font copyright string has 'https://www.sil.org' and OFL text has 'https://www.sil.org'
[code: mismatch]🔥 FAIL Ensure METADATA.pb does not use escaped strings.
-
🔥 FAIL
Found escaped chars at 'Copyright (c) 1994-2024, SIL Global (https://www.sil.org/), with Reserved Font Names Scheherazade and SIL.\n\nThis Font Software is licensed under the SIL Open Font License, Version 1.1.'. Please use an unicode string instead.
[code: escaped-strings] -
🔥 FAIL
Found escaped chars at 'Copyright (c) 1994-2024, SIL Global (https://www.sil.org/), with Reserved Font Names Scheherazade and SIL.\n\nThis Font Software is licensed under the SIL Open Font License, Version 1.1.'. Please use an unicode string instead.
[code: escaped-strings] -
🔥 FAIL
Found escaped chars at 'Copyright (c) 1994-2024, SIL Global (https://www.sil.org/), with Reserved Font Names Scheherazade and SIL.\n\nThis Font Software is licensed under the SIL Open Font License, Version 1.1.'. Please use an unicode string instead.
[code: escaped-strings] -
🔥 FAIL
Found escaped chars at 'Copyright (c) 1994-2024, SIL Global (https://www.sil.org/), with Reserved Font Names Scheherazade and SIL.\n\nThis Font Software is licensed under the SIL Open Font License, Version 1.1.'. Please use an unicode string instead.
[code: escaped-strings]
🔥 FAIL METADATA.pb font.full_name and font.post_script_name fields have equivalent values ?
- 🔥 FAIL
METADATA.pb font full_name = "Scheherazade New" does not match post_script_name = "ScheherazadeNew-Regular"
[code: mismatch]
🔥 FAIL Name table entries should not contain line-breaks.
-
🔥 FAIL
Name entry COPYRIGHT_NOTICE on platform WINDOWS contains a line-break.
[code: line-break] -
🔥 FAIL
Name entry LICENSE_DESCRIPTION on platform WINDOWS contains a line-break.
[code: line-break]
🔥 FAIL Copyright notices match canonical pattern in fonts
- 🔥 FAIL
Name Table entry: Copyright notices should match a pattern similar to:
"Copyright 2020 The Familyname Project Authors (git url)"
But instead we have got:
"Copyright (c) 1994-2024, SIL Global (https://www.sil.org/), with Reserved Font Names "Scheherazade" and "SIL".
This Font Software is licensed under the SIL Open Font License, Version 1.1."
[code: bad-notice-format]- 🔥 FAIL
METADATA.pb: Copyright notices should match a pattern similar to:
"Copyright 2020 The Familyname Project Authors (git url)"
But instead we have got:
"Copyright (c) 1994-2024, SIL Global (https://www.sil.org/), with Reserved Font Names "Scheherazade" and "SIL".
This Font Software is licensed under the SIL Open Font License, Version 1.1."
[code: bad-notice-format]🔥 FAIL Check license file has good copyright string.
- 🔥 FAIL
First line in license file is:
"copyright (c) 1994-2024, sil global (https://www.sil.org/),"
which does not match the expected format, similar to:
"Copyright 2022 The Familyname Project Authors (git url)"
[code: bad-format]🔥 FAIL Check copyright namerecords match license file.
- 🔥 FAIL
License file OFL.txt exists but NameID 13 (LICENSE DESCRIPTION) value on platform 3 (WINDOWS) is not specified for that. Value was: "Copyright (c) 1994-2024, SIL Global (https://www.sil.org/), with Reserved Font Names "Scheherazade" and "SIL".
This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is copied below, and is also available with a FAQ at: https://openfontlicense.org/
SIL OPEN FONT LICENSE Version 1.1 - 26 February 2007
PREAMBLE The goals of the Open Font License (OFL) are to stimulate worldwide development of collaborative font projects, to support the font creation efforts of academic and linguistic communities, and to provide a free and open framework in which fonts may be shared and improved in partnership with others.
The OFL allows the licensed fonts to be used, studied, modified and redistributed freely as long as they are not sold by themselves. The fonts, including any derivative works, can be bundled, embedded, redistributed and/or sold with any software provided that any reserved names are not used by derivative works. The fonts and derivatives, however, cannot be released under any other type of license. The requirement for fonts to remain under this license does not apply to any document created using the fonts or their derivatives.
DEFINITIONS "Font Software" refers to the set of files released by the Copyright Holder(s) under this license and clearly marked as such. This may include source files, build scripts and documentation.
"Reserved Font Name" refers to any names specified as such after the copyright statement(s).
"Original Version" refers to the collection of Font Software components as distributed by the Copyright Holder(s).
"Modified Version" refers to any derivative made by adding to, deleting, or substituting -- in part or in whole -- any of the components of the Original Version, by changing formats or by porting the Font Software to a new environment.
"Author" refers to any designer, engineer, programmer, technical writer or other person who contributed to the Font Software.
PERMISSION & CONDITIONS Permission is hereby granted, free of charge, to any person obtaining a copy of the Font Software, to use, study, copy, merge, embed, modify, redistribute, and sell modified and unmodified copies of the Font Software, subject to the following conditions:
-
Neither the Font Software nor any of its individual components, in Original or Modified Versions, may be sold by itself.
-
Original or Modified Versions of the Font Software may be bundled, redistributed and/or sold with any software, provided that each copy contains the above copyright notice and this license. These can be included either as stand-alone text files, human-readable headers or in the appropriate machine-readable metadata fields within text or binary files as long as those fields can be easily viewed by the user.
-
No Modified Version of the Font Software may use the Reserved Font Name(s) unless explicit written permission is granted by the corresponding Copyright Holder. This restriction only applies to the primary font name as presented to the users.
-
The name(s) of the Copyright Holder(s) or the Author(s) of the Font Software shall not be used to promote, endorse or advertise any Modified Version, except to acknowledge the contribution(s) of the Copyright Holder(s) and the Author(s) or with their explicit written permission.
-
The Font Software, modified or unmodified, in part or in whole, must be distributed entirely under this license, and must not be distributed under any other license. The requirement for fonts to remain under this license does not apply to any document created using the Font Software.
TERMINATION This license becomes null and void if any of the above conditions are not met.
DISCLAIMER THE FONT SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO ANY WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF COPYRIGHT, PATENT, TRADEMARK, OR OTHER RIGHT. IN NO EVENT SHALL THE COPYRIGHT HOLDER BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, INCLUDING ANY GENERAL, SPECIAL, INDIRECT, INCIDENTAL, OR CONSEQUENTIAL DAMAGES, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF THE USE OR INABILITY TO USE THE FONT SOFTWARE OR FROM OTHER DEALINGS IN THE FONT SOFTWARE." Must be changed to "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: https://openfontlicense.org"
[code: wrong]🔥 FAIL Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- 🔥 FAIL
Font is missing the 'gasp' table. Try exporting the font with autohinting enabled.
If you are dealing with an unhinted font, it can be fixed by running the fonts through the command 'gftools fix-nonhinting'
GFTools is available at https://pypi.org/project/gftools/
[code: lacks-gasp]
⚠️ WARN Are there caret positions declared for every ligature?
⚠️ WARNThis font lacks caret position values for ligature glyphs on its GDEF table.
[code: lacks-caret-pos]
⚠️ WARN Is there kerning info for non-ligated sequences?
⚠️ WARNGPOS table lacks kerning info for the following non-ligated sequences:
- uni034F + uni064D
- uni034F + uni0650
- uni034F + uni0651
- uni0644.init + uni0627.fina
- uni0644.init + uni0671.fina
- uni0644.init + uni0672.fina
- uni0644.init + uni0673.fina
- uni0644.init + uni0773.fina
- uni0644.init + uni0774.fina
- uni0644.init + uni0870.fina
- 134 more.
Use -F or --full-lists to disable shortening of long lists.
[code: lacks-kern-info]⚠️ WARN Check math signs have the same width.
⚠️ WARNThe most common width is 1782 among a set of 6 math glyphs.
The following math glyphs have a different width, though:
Width = 1098: multiply, plus
Width = 1122: equal
Width = 1752: logicalnot
Width = 1327: minus
Width = 1549: approxequal
Width = 1189: notequal
[code: width-outliers]⚠️ WARN Does the font contain a soft hyphen?
⚠️ WARNThis font has a 'Soft Hyphen' character.
[code: softhyphen]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
⚠️ WARNFamily metadata at ofl/scheherazadenew does not have an article.
[code: lacks-article]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
⚠️ WARNThe following codepoints supported by the font are not covered by
any subsets defined in the font's metadata file, and will never
be served. You can solve this by either manually adding additional
subset declarations to METADATA.pb, or by editing the glyphset
definitions.
- U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
- U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
- U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
- U+034F COMBINING GRAPHEME JOINER: not included in any glyphset definition
- U+03C0 GREEK SMALL LETTER PI: try adding one of: yi, greek, math
- U+08E2 ARABIC DISPUTED END OF AYAH: not included in any glyphset definition
- U+2000 EN QUAD: try adding symbols2
- U+2001 EM QUAD: try adding symbols2
- U+2003 EM SPACE: try adding nushu
- U+2004 THREE-PER-EM SPACE: try adding symbols2 67 more.
Use -F or --full-lists to disable shortening of long lists.
Or you can add the above codepoints to one of the subsets supported by the font: arabic
, latin
, latin-ext
, menu
⚠️ WARN On a family update, the DESCRIPTION.en_us.html file should ideally also be updated.
⚠️ WARNThe DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
Please consider mentioning note-worthy improvements made to the family recently.
[code: description-not-updated]
⚠️ WARN Check OFL body text is correct.
⚠️ WARNThe OFL.txt body text is incorrect. Please use https://github.com/googlefonts/Unified-Font-Repository/blob/main/OFL.txt as a template. You should only modify the first line.
Lines changed:
+ with Reserved Font Names "Scheherazade" and "SIL".\n
- This Font Software is licensed under the SIL Open Font License, Version 1.1.\n
+ This Font Software is licensed under the SIL Open Font License, Version 1.1,\n
- https://openfontlicense.org\n
+ https://openfontlicense.org/\n
- -----------------------------------------------------------\n
+ ----------------------------------------------------\n
- -----------------------------------------------------------\n
+ ----------------------------------------------------\n
[code: incorrect-ofl-body-text]⚠️ WARN Do any segments have colinear vectors?
⚠️ WARNThe following glyphs have colinear vectors:
* uni060B (U+060B): L<<461.0,-203.0>--<461.0,-268.0>> -> L<<461.0,-268.0>--<485.0,-547.0>>
* uni0656 (U+0656): L<<162.0,-203.0>--<162.0,-268.0>> -> L<<162.0,-268.0>--<186.0,-547.0>>
* uni0670 (U+0670): L<<286.0,1514.0>--<286.0,1449.0>> -> L<<286.0,1449.0>--<309.0,1170.0>>
* uni0670.large: L<<613.0,1465.0>--<613.0,1399.0>> -> L<<613.0,1399.0>--<671.0,737.0>>
* uni08DA (U+08DA): L<<-184.0,2517.0>--<-184.0,2480.0>> -> L<<-184.0,2480.0>--<-170.0,2321.0>>
* uniFD42.smpl: L<<2487.0,1440.0>--<2487.0,1381.0>> -> L<<2487.0,1381.0>--<2546.0,750.0>>
* uniFD43.smpl: L<<2642.0,1689.0>--<2642.0,1629.0>> -> L<<2642.0,1629.0>--<2701.0,993.0>>
* uniFD44 (U+FD44): L<<426.0,1205.0>--<426.0,1169.0>> -> L<<426.0,1169.0>--<441.0,1014.0>>
* uniFD44.smpl: L<<2829.0,1741.0>--<2829.0,1681.0>> -> L<<2829.0,1681.0>--<2888.0,1045.0>>
* uniFD4E (U+FD4E): L<<1032.0,1937.0>--<1032.0,1897.0>> -> L<<1032.0,1897.0>--<1049.0,1727.0>>
* uniFDFE (U+FDFE): L<<841.0,1690.0>--<841.0,1644.0>> -> L<<841.0,1644.0>--<858.0,1445.0>>
[code: found-colinear-vectors]
⚠️ WARN Check the direction of the outermost contour in each glyph
⚠️ WARNThe following glyphs have a counter-clockwise outer contour:
* uni089C (U+089C) has a counter-clockwise outer contour
* uni08D1 (U+08D1) has a counter-clockwise outer contour
* uni08D2 (U+08D2) has a counter-clockwise outer contour
* uni08E5 (U+08E5) has a counter-clockwise outer contour
* uni08E8 (U+08E8) has a counter-clockwise outer contour
* uni08E8 (U+08E8) has a counter-clockwise outer contour
* uniFD4B (U+FD4B) has a counter-clockwise outer contour
* uniFD4B (U+FD4B) has a counter-clockwise outer contour
[code: ccw-outer-contour]
⚠️ WARN Do outlines contain any jaggy segments?
⚠️ WARNThe following glyphs have jaggy segments:
* uniFD4A (U+FD4A): B<<1067.0,463.5>-<1042.0,567.0>-<1016.0,718.0>>/L<<1016.0,718.0>--<1045.0,653.0>> = 14.274523218836594
* uniFD4C (U+FD4C): L<<445.0,-139.0>--<521.0,-33.0>>/B<<521.0,-33.0>-<513.0,-42.0>-<529.0,-58.0>> = 5.993730138483463
* uniFD4F (U+FD4F): L<<1047.0,36.0>--<1011.0,47.0>>/B<<1011.0,47.0>-<1025.0,46.0>-<1037.0,46.0>> = 12.90520651201125
* uniFDCF (U+FDCF): B<<1197.5,1038.0>-<1187.0,1112.0>-<1179.0,1200.0>>/B<<1179.0,1200.0>-<1168.0,1071.0>-<1156.0,975.5>> = 10.068325329939558
* uniFDFA (U+FDFA): L<<1587.0,33.0>--<1625.0,69.0>>/B<<1625.0,69.0>-<1566.0,-14.0>-<1481.0,-60.0>> = 11.14129196170829
* uniFDFD (U+FDFD): L<<4048.0,144.0>--<4119.0,252.0>>/B<<4119.0,252.0>-<4115.0,243.0>-<4131.5,226.5>> = 9.358726697361368
* uniFDFD (U+FDFD): L<<435.0,283.0>--<506.0,391.0>>/B<<506.0,391.0>-<498.0,382.0>-<515.0,365.5>> = 8.312323664630595
* uniFDFD.smpl: L<<435.0,170.0>--<506.0,278.0>>/B<<506.0,278.0>-<498.0,269.0>-<515.0,252.5>> = 8.312323664630595
* uniFDFD.smpl: L<<4522.0,164.0>--<4593.0,272.0>>/B<<4593.0,272.0>-<4585.0,263.0>-<4602.0,246.5>> = 8.312323664630595
* uniFDFF (U+FDFF): B<<862.5,57.0>-<818.0,111.0>-<801.0,252.0>>/L<<801.0,252.0>--<830.0,173.0>> = 13.282792865840563
[code: found-jaggy-segments]
⚠️ WARN Do outlines contain any semi-vertical or semi-horizontal lines?
⚠️ WARNThe following glyphs have semi-vertical/semi-horizontal lines:
* uni0890 (U+0890): L<<703.0,1421.0>--<1245.0,1423.0>>
* uni0890.2: L<<703.0,1421.0>--<1245.0,1423.0>>
* uni0890.3: L<<953.0,1421.0>--<1495.0,1423.0>>
* uni0890.4: L<<1173.0,1421.0>--<1715.0,1423.0>>
* uni0891 (U+0891): L<<571.0,1423.0>--<1113.0,1421.0>>
* uni0891.2: L<<571.0,1423.0>--<1113.0,1421.0>>
* uni0891.3: L<<821.0,1423.0>--<1363.0,1421.0>>
* uni0891.4: L<<1041.0,1423.0>--<1583.0,1421.0>>
[code: found-semi-vertical]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
⚠️ WARNThis font file does not have a 'meta' table.
[code: lacks-meta-table]
ℹ️ INFO Show hinting filesize impact.
- ℹ️ INFO
Hinting filesize impact:
ofl/scheherazadenew/ScheherazadeNew-Regular.ttf | |
---|---|
Dehinted Size | 310.2kb |
Hinted Size | 310.2kb |
Increase | -24 bytes |
Change | -0.0 % |
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- loca
- GPOS
- GSUB
- JSTF
[code: optional-tables]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
- ℹ️ INFO
Please consider adding a family.minisite_url entry.
[code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
- ℹ️ INFO
Found a git repo URL: https://github.com/silnrsi/font-scheherazade
[code: url-found]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
- ℹ️ INFO
This font doesn't have an ARTICLE.en_us.html file.
[code: missing-article]
ℹ️ INFO EPAR table present in font?
- ℹ️ INFO
EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818
[code: lacks-EPAR]
[1] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
4 | 0 | 37 | 53 | 266 | 33 | 569 | 0 |
0% | 0% | 4% | 6% | 28% | 3% | 59% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
@emmamarichal |
We'll proceed with this as in Abyssinica. |
Taken from the upstream repo https://github.com/silnrsi/font-scheherazade at commit silnrsi/font-scheherazade@7419734.
PR Checklist:
minisite_url
definition in the METADATA.pb file for commissioned projectsprimary_script
definition in the METADATA.pb file for all projects that have a primary non-Latin based language support targetsubsets
definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsetschinese-hongkong
,chinese-simplified
,chinese-traditional
,korean
,japanese
.