Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noto Sans Nandinagari: Version 1.003; ttfautohint (v1.8.4.7-5d5b) added #8282

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

simoncozens
Copy link
Collaborator

Taken from the upstream repo https://github.com/notofonts/nandinagari at commit notofonts/nandinagari@c751456.

PR Checklist:

  • minisite_url definition in the METADATA.pb file for commissioned projects
  • tags are added for NEW FONTS
  • primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • subsets definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsets chinese-hongkong, chinese-simplified, chinese-traditional, korean, japanese.
  • Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Diffenator2 regression checks for revisions on all projects that are currently in production
  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet

Copy link

github-actions bot commented Oct 7, 2024

FontBakery report

fontbakery version: 0.13.0a1

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[1] NotoSansNandinagari-Regular.ttf
⚠️ WARN Checking that the typoAscender exceeds the yMax of the /Agrave.
  • ⚠️ WARN

    OS/2.sTypoAscender value should be greater than 944, but got 900 instead


    [code: typoAscender]

All other checks

[24] NotoSansNandinagari-Regular.ttf
💥 ERROR Check if the vertical metrics of a CJK family are similar to the same family hosted on Google Fonts.
  • 💥 ERROR

    'Font' object is not subscriptable


    [code: error]
💥 ERROR Check if the vertical metrics of a family are similar to the same family hosted on Google Fonts.
  • 💥 ERROR

    'Font' object is not subscriptable


    [code: error]
💥 ERROR Check if the axes match between the font and the Google Fonts version.
  • 💥 ERROR

    'Font' object is not subscriptable


    [code: error]
🔥 FAIL Does DESCRIPTION file contain broken links?
🔥 FAIL DESCRIPTION.en_us.html must have more than 200 bytes.
  • 🔥 FAIL

    DESCRIPTION.en_us.html must have size larger than 200 bytes.


    [code: too-short]
⚠️ WARN Check if each glyph has the recommended amount of contours.
  • ⚠️ WARN

    This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: aogonek	Contours detected: 3	Expected: 2
  • Glyph name: uogonek Contours detected: 2 Expected: 1

  • Glyph name: aogonek Contours detected: 3 Expected: 2

  • Glyph name: uogonek Contours detected: 2 Expected: 1


[code: contour-count]

⚠️ WARN Check font contains no unreachable glyphs
  • ⚠️ WARN

    The following glyphs could not be reached by codepoint or substitution rules:

- DdhaVirama.Nnagari.ss01

- DhaVirama.Nnagari.ss01

- HaVirama.Nnagari.ss01

- NULL

- NyaVirama.Nnagari

- PhaVirama.Nnagari.ss01

- TthaVirama.Nnagari.ss01

[code: unreachable-glyphs]

⚠️ WARN Glyph names are all valid?
  • ⚠️ WARN

    The following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit:
    DoubleAnusvaraAntargomukha.Nnagari


    [code: legacy-long-names]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Article page is too short!


    [code: length-requirements-not-met]

  • ⚠️ WARN

    Article page lacks visual assets.


    [code: missing-visual-asset]

⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: cherokee, math, tifinagh, coptic
  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
  • U+0307 COMBINING DOT ABOVE: try adding one of: tifinagh, hebrew, math, todhri, tai-le, coptic, duployan, malayalam, old-permic, syriac, canadian-aboriginal
  • U+030A COMBINING RING ABOVE: try adding one of: duployan, syriac
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le
  • U+0326 COMBINING COMMA BELOW: try adding math 5 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu, nandinagari

[code: unreachable-subsetting]
⚠️ WARN Shapes languages in all GF glyphsets.
  • ⚠️ WARN

    GF_TransLatin_Pinyin glyphset:

WARN messages Languages
Some auxiliary glyphs were missing: Ŀ, ŀ ca_Latn (Catalan)
Some auxiliary glyphs were missing: ſ de_Latn (German) and fr_Latn (French)
Some auxiliary glyphs were missing: Ŋ, ŋ, Ŧ, ŧ, Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ fi_Latn (Finnish)
Some auxiliary glyphs were missing: Ŋ, ŋ, Ŧ, ŧ nb_Latn (Norwegian Bokmål)
Some auxiliary glyphs were missing: IJ, ij nl_Latn (Dutch)
[code: warning-language-shaping]
⚠️ WARN DESCRIPTION.en_us.html should end in a linebreak.
  • ⚠️ WARN

    The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it.


    [code: missing-eof-linebreak]
⚠️ WARN On a family update, the DESCRIPTION.en_us.html file should ideally also be updated.
  • ⚠️ WARN

    The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
    Please consider mentioning note-worthy improvements made to the family recently.


    [code: description-not-updated]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
  • ⚠️ WARN

    The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̧̀ į̧́ į̧̂ į̧̃

Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers), Dutch (Latn, 31,709,104 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Navajo (Latn, 166,319 speakers), Bete-Bendi (Latn, 100,000 speakers), Fur (Latn, 1,230,163 speakers), Kom (Latn, 360,685 speakers), Bafut (Latn, 158,146 speakers), Lugbara (Latn, 2,200,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Mundani (Latn, 34,000 speakers), Dii (Latn, 71,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Ekpeye (Latn, 226,000 speakers), Avokaya (Latn, 100,000 speakers), Makaa (Latn, 221,000 speakers), South Central Banda (Latn, 244,000 speakers), Gulay (Latn, 250,478 speakers), Basaa (Latn, 332,940 speakers), Sar (Latn, 500,000 speakers), Mfumte (Latn, 79,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Igbo (Latn, 27,823,640 speakers), Ejagham (Latn, 120,000 speakers), Yala (Latn, 200,000 speakers), Dan (Latn, 1,099,244 speakers), Aghem (Latn, 38,843 speakers), Ma’di (Latn, 584,000 speakers), Koonzime (Latn, 40,000 speakers), Ebira (Latn, 2,200,000 speakers), Mango (Latn, 77,000 speakers), Vute (Latn, 21,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Nateni (Latn, 100,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Cicipu (Latn, 44,000 speakers), Nzakara (Latn, 50,000 speakers), Zapotec (Latn, 490,000 speakers), Southern Kisi (Latn, 360,000 speakers).

[code: soft-dotted]
⚠️ WARN Do any segments have colinear vectors?
  • ⚠️ WARN

    The following glyphs have colinear vectors:

* GaDha.Nnagari.ss02: L<<574.0,-243.0>--<574.0,-243.0>> -> L<<574.0,-243.0>--<574.0,-243.0>>

* KaTaRa.Nnagari.ss03: L<<390.0,-187.0>--<390.0,-187.0>> -> L<<390.0,-187.0>--<390.0,-187.0>>

* MaRa.Nnagari: L<<313.0,406.0>--<320.0,406.0>> -> L<<320.0,406.0>--<492.0,406.0>>

* MaRa.Nnagari: L<<492.0,335.0>--<320.0,335.0>> -> L<<320.0,335.0>--<317.0,335.0>>

* MatraAa1.Nnagari: L<<-264.0,623.0>--<104.0,622.0>> -> L<<104.0,622.0>--<154.0,622.0>>

* MatraAaReph1.Nnagari: L<<-264.0,623.0>--<104.0,622.0>> -> L<<104.0,622.0>--<154.0,622.0>>

* MatraAu1.Nnagari: L<<-264.0,623.0>--<104.0,622.0>> -> L<<104.0,622.0>--<154.0,622.0>>

* MatraAuReph1.Nnagari: L<<-264.0,623.0>--<104.0,622.0>> -> L<<104.0,622.0>--<154.0,622.0>>

* MatraO1.Nnagari: L<<-264.0,623.0>--<104.0,622.0>> -> L<<104.0,622.0>--<154.0,622.0>>

* MatraOReph1.Nnagari: L<<-264.0,623.0>--<104.0,622.0>> -> L<<104.0,622.0>--<154.0,622.0>>

* 3 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-colinear-vectors]
⚠️ WARN Do outlines contain any jaggy segments?
  • ⚠️ WARN

    The following glyphs have jaggy segments:

* TaMa.Nnagari.ss01: B<<432.0,330.5>-<431.0,373.0>-<430.0,415.0>>/L<<430.0,415.0>--<430.0,375.0>> = 1.3639275316029233

[code: found-jaggy-segments]

⚠️ WARN Do outlines contain any semi-vertical or semi-horizontal lines?
  • ⚠️ WARN

    The following glyphs have semi-vertical/semi-horizontal lines:

* Dda.Nnagari (U+119BA): L<<371.0,559.0>--<60.0,558.0>>

* DdaVirama.Nnagari: L<<371.0,559.0>--<60.0,558.0>>

* JaNyaVa.Nnagari: L<<827.0,334.0>--<826.0,-201.0>>

* MatraAa1.Nnagari: L<<-264.0,623.0>--<104.0,622.0>>

* MatraAa1.Nnagari: L<<76.0,558.0>--<-179.0,559.0>>

* MatraAaReph1.Nnagari: L<<-264.0,623.0>--<104.0,622.0>>

* MatraAaReph1.Nnagari: L<<76.0,558.0>--<-179.0,559.0>>

* MatraAu1.Nnagari: L<<-264.0,623.0>--<104.0,622.0>>

* MatraAu1.Nnagari: L<<76.0,558.0>--<-179.0,559.0>>

* MatraAuReph1.Nnagari: L<<-264.0,623.0>--<104.0,622.0>>

* 10 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-semi-vertical]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/notosansnandinagari


    [code: family-path]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/notosansnandinagari/NotoSansNandinagari-Regular.ttf
Dehinted Size 162.9kb
Hinted Size 247.0kb
Increase 84.1kb
Change 51.7 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- cvt 

- fpgm

- loca

- prep

- GPOS

- GSUB

- gasp

- vhea

- vmtx

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    All of the fonts lack a STAT table.


    [code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
3 0 2 14 66 7 161 0
1% 0% 1% 6% 26% 3% 64% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@m4rc1e m4rc1e merged commit 839c63e into main Oct 15, 2024
7 of 8 checks passed
@m4rc1e m4rc1e deleted the gftools_packager_ofl_notosansnandinagari branch October 15, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants