-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exo 2: Version 2.010 added #8273
Conversation
Taken from the upstream repo https://github.com/googlefonts/Exo-2.0 at commit googlefonts/Exo-2.0@f83ea8a.
@vv-monsalve This is the small fix to update copyright URL and avoid confusions with the repos! |
This comment was marked as outdated.
This comment was marked as outdated.
FontBakery reportfontbakery version: 0.13.0a1 Check results[20] Exo2[wght].ttf🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
But: HTML description has 'github.com/googlefonts/Exo-2' [code: mismatch]
|
WARN messages | Languages |
---|---|
Some auxiliary glyphs were missing: ſ | de_Latn (German) and fr_Latn (French) |
Some auxiliary glyphs were missing: Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ | fi_Latn (Finnish) |
⚠️ WARN Ensure dotted circle glyph is present and can attach marks.
⚠️ WARNNo dotted circle glyph present
[code: missing-dotted-circle]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
⚠️ WARNThe dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌ і́ ị̀ ị́ ị̂ ị̃ ị̄
The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̉ į̊ į̋ į̏ į̑ į̒ į̛̀ į̛́ į̛̂ į̛̃ į̛̄ į̛̆ į̛̇ į̛̈ į̛̉ į̛̊ į̛̋
Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Ma’di (Latn, 584,000 speakers), Lithuanian (Latn, 2,357,094 speakers), Ebira (Latn, 2,200,000 speakers), Igbo (Latn, 27,823,640 speakers), Navajo (Latn, 166,319 speakers), Ekpeye (Latn, 226,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Belarusian (Cyrl, 10,064,517 speakers).
Your font does not cover the following languages that require the soft-dotted feature: Makaa (Latn, 221,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Nzakara (Latn, 50,000 speakers), Mango (Latn, 77,000 speakers), Cicipu (Latn, 44,000 speakers), Dan (Latn, 1,099,244 speakers), Yala (Latn, 200,000 speakers), Nateni (Latn, 100,000 speakers), Koonzime (Latn, 40,000 speakers), Dii (Latn, 71,000 speakers), Fur (Latn, 1,230,163 speakers), South Central Banda (Latn, 244,000 speakers), Avokaya (Latn, 100,000 speakers), Gulay (Latn, 250,478 speakers), Vute (Latn, 21,000 speakers), Kom (Latn, 360,685 speakers), Bafut (Latn, 158,146 speakers), Sar (Latn, 500,000 speakers), Aghem (Latn, 38,843 speakers), Mundani (Latn, 34,000 speakers), Ejagham (Latn, 120,000 speakers), Zapotec (Latn, 490,000 speakers), Mfumte (Latn, 79,000 speakers), Lugbara (Latn, 2,200,000 speakers), Basaa (Latn, 332,940 speakers), Southern Kisi (Latn, 360,000 speakers), Bete-Bendi (Latn, 100,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers).
[code: soft-dotted]⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
⚠️ WARNThis font file does not have a 'meta' table.
[code: lacks-meta-table]
⚠️ WARN Checking OS/2 achVendID.
⚠️ WARNOS/2 VendorID value 'NONE' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
[code: unknown]
ℹ️ INFO Show hinting filesize impact.
- ℹ️ INFO
Hinting filesize impact:
ofl/exo2/Exo2[wght].ttf | |
---|---|
Dehinted Size | 296.8kb |
Hinted Size | 296.8kb |
Increase | 24 bytes |
Change | 0.0 % |
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- loca
- prep
- GPOS
- GSUB
- gasp
[code: optional-tables]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
- ℹ️ INFO
Please consider adding a family.minisite_url entry.
[code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
- ℹ️ INFO
Found a git repo URL: https://github.com/googlefonts/Exo-2.0
[code: url-found]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
- ℹ️ INFO
This font doesn't have an ARTICLE.en_us.html file.
[code: missing-article]
ℹ️ INFO EPAR table present in font?
- ℹ️ INFO
EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818
[code: lacks-EPAR]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges][20] Exo2-Italic[wght].ttf
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
- 🔥 FAIL
Repository URL is https://github.com/googlefonts/Exo-2.0
But: HTML description has 'github.com/googlefonts/Exo-2'
[code: mismatch]⚠️ WARN Detect any interpolation issues in the font.
⚠️ WARNInterpolation issues were found in the font:
- Contour 0 point 37 in glyph 'uni0431' has a kink between location wght=100 and location wght=900
- Contour 0 point 81 in glyph 'w' has a kink between location wght=100 and location wght=900
[code: interpolation-issues]
⚠️ WARN Is there kerning info for non-ligated sequences?
⚠️ WARNGPOS table lacks kerning info for the following non-ligated sequences:
- f + f
- f + i
- f + l
[code: lacks-kern-info]
⚠️ WARN Check math signs have the same width.
⚠️ WARNThe most common width is 586 among a set of 3 math glyphs.
The following math glyphs have a different width, though:
Width = 547: plus
Width = 526: less, greater
Width = 587: logicalnot
Width = 585: plusminus
Width = 525: multiply
Width = 567: divide
Width = 613: notequal
Width = 565: lessequal
Width = 563: greaterequal
[code: width-outliers]⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
⚠️ WARNFamily metadata at ofl/exo2 does not have an article.
[code: lacks-article]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
⚠️ WARNThe following codepoints supported by the font are not covered by
any subsets defined in the font's metadata file, and will never
be served. You can solve this by either manually adding additional
subset declarations to METADATA.pb, or by editing the glyphset
definitions.
- U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
- U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
- U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
- U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: tifinagh, math, coptic, cherokee
- U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
- U+0307 COMBINING DOT ABOVE: try adding one of: tifinagh, tai-le, duployan, syriac, todhri, math, hebrew, canadian-aboriginal, old-permic, malayalam, coptic
- U+030A COMBINING RING ABOVE: try adding one of: syriac, duployan
- U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee
- U+030C COMBINING CARON: try adding one of: tai-le, cherokee
- U+030F COMBINING DOUBLE GRAVE ACCENT: not included in any glyphset definition 57 more.
Use -F or --full-lists to disable shortening of long lists.
Or you can add the above codepoints to one of the subsets supported by the font: cyrillic
, cyrillic-ext
, latin
, latin-ext
, menu
, vietnamese
⚠️ WARN Shapes languages in all GF glyphsets.
⚠️ WARNGF_Phonetics_SinoExt glyphset:
WARN messages | Languages |
---|---|
Some auxiliary glyphs were missing: ſ | de_Latn (German) and fr_Latn (French) |
Some auxiliary glyphs were missing: Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ | fi_Latn (Finnish) |
⚠️ WARN Ensure dotted circle glyph is present and can attach marks.
⚠️ WARNNo dotted circle glyph present
[code: missing-dotted-circle]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
⚠️ WARNThe dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌ і́ ị̀ ị́ ị̂ ị̃ ị̄
The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̉ į̊ į̋ į̏ į̑ į̒ į̛̀ į̛́ į̛̂ į̛̃ į̛̄ į̛̆ į̛̇ į̛̈ į̛̉ į̛̊ į̛̋
Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Ma’di (Latn, 584,000 speakers), Lithuanian (Latn, 2,357,094 speakers), Ebira (Latn, 2,200,000 speakers), Navajo (Latn, 166,319 speakers), Ekpeye (Latn, 226,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Belarusian (Cyrl, 10,064,517 speakers).
Your font does not cover the following languages that require the soft-dotted feature: Makaa (Latn, 221,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Nzakara (Latn, 50,000 speakers), Mango (Latn, 77,000 speakers), Cicipu (Latn, 44,000 speakers), Dan (Latn, 1,099,244 speakers), Yala (Latn, 200,000 speakers), Nateni (Latn, 100,000 speakers), Koonzime (Latn, 40,000 speakers), Dii (Latn, 71,000 speakers), Fur (Latn, 1,230,163 speakers), South Central Banda (Latn, 244,000 speakers), Avokaya (Latn, 100,000 speakers), Igbo (Latn, 27,823,640 speakers), Gulay (Latn, 250,478 speakers), Vute (Latn, 21,000 speakers), Kom (Latn, 360,685 speakers), Bafut (Latn, 158,146 speakers), Sar (Latn, 500,000 speakers), Aghem (Latn, 38,843 speakers), Mundani (Latn, 34,000 speakers), Ejagham (Latn, 120,000 speakers), Zapotec (Latn, 490,000 speakers), Mfumte (Latn, 79,000 speakers), Lugbara (Latn, 2,200,000 speakers), Basaa (Latn, 332,940 speakers), Southern Kisi (Latn, 360,000 speakers), Bete-Bendi (Latn, 100,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers).
[code: soft-dotted]⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
⚠️ WARNThis font file does not have a 'meta' table.
[code: lacks-meta-table]
⚠️ WARN Checking OS/2 achVendID.
⚠️ WARNOS/2 VendorID value 'NONE' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
[code: unknown]
ℹ️ INFO Show hinting filesize impact.
- ℹ️ INFO
Hinting filesize impact:
ofl/exo2/Exo2-Italic[wght].ttf | |
---|---|
Dehinted Size | 295.4kb |
Hinted Size | 295.5kb |
Increase | 24 bytes |
Change | 0.0 % |
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- loca
- prep
- GPOS
- GSUB
- gasp
[code: optional-tables]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
- ℹ️ INFO
Please consider adding a family.minisite_url entry.
[code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
- ℹ️ INFO
Found a git repo URL: https://github.com/googlefonts/Exo-2.0
[code: url-found]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
- ℹ️ INFO
This font doesn't have an ARTICLE.en_us.html file.
[code: missing-article]
ℹ️ INFO EPAR table present in font?
- ℹ️ INFO
EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818
[code: lacks-EPAR]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges][1] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 2 | 20 | 77 | 19 | 370 | 0 |
0% | 0% | 0% | 4% | 16% | 4% | 76% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
@felipesanches Could FB be unhappy with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Fb needs fixing as Viv pointed out.
Taken from the upstream repo https://github.com/googlefonts/Exo-2.0 at commit googlefonts/Exo-2.0@f83ea8a.
PR Checklist:
minisite_url
definition in the METADATA.pb file for commissioned projectsprimary_script
definition in the METADATA.pb file for all projects that have a primary non-Latin based language support targetsubsets
definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsetschinese-hongkong
,chinese-simplified
,chinese-traditional
,korean
,japanese
.