Abort PM4/GFXR capture when the device is locked or app is not actively#758
Open
elviscapiaq wants to merge 4 commits intogoogle:mainfrom
Open
Abort PM4/GFXR capture when the device is locked or app is not actively#758elviscapiaq wants to merge 4 commits intogoogle:mainfrom
elviscapiaq wants to merge 4 commits intogoogle:mainfrom
Conversation
Collaborator
Author
|
Tested on Android XR device and a pixel 4 cellphone. |
wangra-google
previously approved these changes
Feb 19, 2026
wangra-google
previously approved these changes
Feb 19, 2026
wangra-google
previously approved these changes
Feb 23, 2026
capture_service/dive_client_cli.cc
Outdated
| // `wait_for_ready_to_retrieve` will skip subsequent steps. | ||
| absl::StatusOr<GfxrCaptureControlFlow> TriggerGfxrCapture( | ||
| const AndroidDevice& device, const GlobalOptions& options, | ||
| AndroidDevice* device, const GlobalOptions& options, |
Collaborator
There was a problem hiding this comment.
Would it be possible to just pass const CommandContext& ctx here rather than AndroidDevice* device, const GlobalOptions& options? In general passing around raw pointers is better avoided, I believe https://google.github.io/styleguide/cppguide.html#Ownership_and_Smart_Pointers
wangra-google
approved these changes
Feb 26, 2026
GrantComm
reviewed
Feb 26, 2026
Comment on lines
592
to
+594
| void TraceDialog::OnTraceClicked() | ||
| { | ||
| Dive::AndroidDevice* device = Dive::GetDeviceManager().GetDevice(); |
Collaborator
There was a problem hiding this comment.
Can this check be put into a separate function? Something like Dive::AndroidDevice* TraceDialog::GetAndValidateDevice() so that the block isn't duplicated here and in OnGfxrCaptureClicked?
angela28chen
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
running