Skip to content

Abort GFXR replay if device is not ready and give the user a reminder#753

Merged
angela28chen merged 4 commits intogoogle:mainfrom
angela28chen:screen-off-reminder
Feb 24, 2026
Merged

Abort GFXR replay if device is not ready and give the user a reminder#753
angela28chen merged 4 commits intogoogle:mainfrom
angela28chen:screen-off-reminder

Conversation

@angela28chen
Copy link
Collaborator

@angela28chen angela28chen commented Feb 17, 2026 •
edited
Loading

Will check that the device:

  • Has screen on
  • Is unlocked
image

@angela28chen angela28chen marked this pull request as ready for review February 17, 2026 21:50
@angela28chen angela28chen changed the title Halt GFXR replay if screen is off and give the user a reminder Abort GFXR replay if screen is off and give the user a reminder Feb 17, 2026
footballhead
footballhead reviewed Feb 18, 2026
View reviewed changes
footballhead
footballhead reviewed Feb 18, 2026
View reviewed changes
@angela28chen angela28chen enabled auto-merge (squash) February 18, 2026 20:04
footballhead
footballhead previously approved these changes Feb 19, 2026
View reviewed changes
@elviscapiaq
Copy link
Collaborator

elviscapiaq commented Feb 19, 2026

@angela28chen , I just realized that probably this PR overlaps with this one: #758

@elviscapiaq
Copy link
Collaborator

elviscapiaq commented Feb 19, 2026 •
edited
Loading

As we discussed offline, I believe the command adb shell dumpsys input\_method | grep mInteractive=true only verifies that the screen is on. However, for PM4/GFXR direct captures, we also need the app to be running in the foreground, not the background. I wrote a different command in the PR (#758) that checks both if the screen is on and if the app is running in the foreground. I wanted to leave this here as it might also apply to Replay.

angela28chen
angela28chen commented Feb 19, 2026
View reviewed changes
GrantComm
GrantComm previously approved these changes Feb 19, 2026
View reviewed changes
footballhead
footballhead previously approved these changes Feb 20, 2026
View reviewed changes
@angela28chen angela28chen dismissed stale reviews from footballhead and GrantComm via b0cbe5d February 20, 2026 16:40
@angela28chen angela28chen enabled auto-merge (squash) February 20, 2026 16:41
footballhead
footballhead previously approved these changes Feb 20, 2026
View reviewed changes
@angela28chen angela28chen changed the title Abort GFXR replay if screen is off and give the user a reminder Abort GFXR replay if device is not ready and give the user a reminder Feb 20, 2026
@angela28chen angela28chen enabled auto-merge (squash) February 20, 2026 17:50
@angela28chen angela28chen merged commit 8e49220 into google:main Feb 24, 2026
11 checks passed
@angela28chen angela28chen deleted the screen-off-reminder branch February 24, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@footballhead footballhead footballhead approved these changes

@wangra-google wangra-google wangra-google approved these changes

@elviscapiaq elviscapiaq Awaiting requested review from elviscapiaq

@GrantComm GrantComm Awaiting requested review from GrantComm

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@angela28chen @elviscapiaq @footballhead @GrantComm @wangra-google