Skip to content

Do not use Entropic and Focus Function together (OSS-Fuzz#4242). #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 3, 2020
Merged

Do not use Entropic and Focus Function together (OSS-Fuzz#4242). #1942

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
691c90b
Do not use Entropic and Focus Function together (#4242).
Dor1s Aug 3, 2020
e8b5b30
reorder entropic and dataflow as per review suggestion
Dor1s Aug 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/python/bot/fuzzers/libfuzzer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1740,10 +1740,16 @@ def pick_strategies(strategy_pool,
is_mutations_run = (not environment.is_ephemeral() and
candidate_generator != engine_common.Generator.NONE)

if strategy_pool.do_strategy(strategy.ENTROPIC_STRATEGY):
arguments.append(constants.ENTROPIC_ARGUMENT)
fuzzing_strategies.append(strategy.ENTROPIC_STRATEGY.name)

# Depends on the presense of DFSan instrumented build.
dataflow_build_dir = environment.get_value('DATAFLOW_BUILD_DIR')
use_dataflow_tracing = (
dataflow_build_dir and
# Focus function is not compatible with entropic mode.
strategy.ENTROPIC_STRATEGY.name not in fuzzing_strategies and
strategy_pool.do_strategy(strategy.DATAFLOW_TRACING_STRATEGY))
if use_dataflow_tracing:
dataflow_binary_path = os.path.join(
Expand Down Expand Up @@ -1789,10 +1795,6 @@ def pick_strategies(strategy_pool,
fuzzer_path)):
fuzzing_strategies.append(strategy.RECOMMENDED_DICTIONARY_STRATEGY.name)

if strategy_pool.do_strategy(strategy.ENTROPIC_STRATEGY):
arguments.append(constants.ENTROPIC_ARGUMENT)
fuzzing_strategies.append(strategy.ENTROPIC_STRATEGY.name)

if strategy_pool.do_strategy(strategy.VALUE_PROFILE_STRATEGY):
arguments.append(constants.VALUE_PROFILE_ARGUMENT)
fuzzing_strategies.append(strategy.VALUE_PROFILE_STRATEGY.name)
Expand Down