Skip to content

Conversation

@Dor1s
Copy link
Contributor

@Dor1s Dor1s commented Aug 3, 2020

No description provided.

@google-cla google-cla bot added the cla: yes CLA signed. label Aug 3, 2020
@Dor1s
Copy link
Contributor Author

Dor1s commented Aug 3, 2020

/gcbrun


if strategy_pool.do_strategy(strategy.ENTROPIC_STRATEGY):
# Entropic isn't compatible with focus function.
if (strategy_pool.do_strategy(strategy.ENTROPIC_STRATEGY) and not any(
Copy link
Collaborator

@inferno-chromium inferno-chromium Aug 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we prioritize dataflow over entropic or entropic over dataflow. i think entropic over dataflow, so move the block up and then check entropic not in any arguments in dataflow check ? if does not matter, skip.

Copy link
Collaborator

@jonathanmetzman jonathanmetzman Aug 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would help me entropic is actually running 50% of the time so I have a preference for prioritizing entropic.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for the sake of discussion, I think it's better to give the preference to dataflow, as it's supposed to be useful more often (i.e. when the corpus is saturated) compared to entropic (which presumably is most effective in the first days / weeks of a fuzz target lifetime).

But I'll swap these as per your suggestion, since anyway dataflow isn't yet deployed and instead of having this case-by-case preference decisions we need to refactor the strategy selection algorithm: #1943

@Dor1s
Copy link
Contributor Author

Dor1s commented Aug 3, 2020

/gcbrun

Copy link
Collaborator

@inferno-chromium inferno-chromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Dor1s Dor1s merged commit 1f375a5 into master Aug 3, 2020
@oliverchang oliverchang deleted the entropic_focus branch January 21, 2021 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes CLA signed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants