-
Notifications
You must be signed in to change notification settings - Fork 588
Do not use Entropic and Focus Function together (OSS-Fuzz#4242). #1942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/gcbrun |
src/python/bot/fuzzers/libfuzzer.py
Outdated
|
|
||
| if strategy_pool.do_strategy(strategy.ENTROPIC_STRATEGY): | ||
| # Entropic isn't compatible with focus function. | ||
| if (strategy_pool.do_strategy(strategy.ENTROPIC_STRATEGY) and not any( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we prioritize dataflow over entropic or entropic over dataflow. i think entropic over dataflow, so move the block up and then check entropic not in any arguments in dataflow check ? if does not matter, skip.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would help me entropic is actually running 50% of the time so I have a preference for prioritizing entropic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for the sake of discussion, I think it's better to give the preference to dataflow, as it's supposed to be useful more often (i.e. when the corpus is saturated) compared to entropic (which presumably is most effective in the first days / weeks of a fuzz target lifetime).
But I'll swap these as per your suggestion, since anyway dataflow isn't yet deployed and instead of having this case-by-case preference decisions we need to refactor the strategy selection algorithm: #1943
|
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
No description provided.