Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

Update upstream Closure Compiler version #83

Closed
wants to merge 1 commit into from

Conversation

gaearon
Copy link

@gaearon gaearon commented Nov 13, 2017

I'm not sure what the policy is about upstream updates, but this is updating to GCC's current master. The tests pass (except for the one that's already failing on master):

screen shot 2017-11-13 at 1 50 18 pm

I want this so that we can unfork this package in React (currently had to fork to get google/closure-compiler#2707 in).

If you'd like, I can also add docs for the new renaming option, now that it is available here.

@MatrixFrog
Copy link
Contributor

Generally we only bump the version once a month when the other NPM package, and the Maven release, are updated, so that all three are in sync.

@gaearon
Copy link
Author

gaearon commented Nov 14, 2017

Ah okay, thanks for explaining! Maybe worth noting as to a casual observer it's not clear if there is a schedule or it's done in an ad hoc way. But I understand this is probably not a priority 🙂

@gaearon gaearon closed this Nov 14, 2017
@gaearon
Copy link
Author

gaearon commented Dec 6, 2017

the other NPM package

Which npm package would that be?

the Maven release

It seems like there were releases for October 23 and November 12: https://github.com/google/closure-compiler/wiki/Releases. My comment was on November 13, so there already has been a released by then.

Should I send another PR updating to that version?

@gaearon gaearon deleted the update-gcc branch December 6, 2017 17:23
@MatrixFrog MatrixFrog changed the title Update upstream GCC Update upstream Closure Compiler version Dec 6, 2017
@MatrixFrog
Copy link
Contributor

If https://www.npmjs.com/package/google-closure-compiler-js is behind a version or two, then https://www.npmjs.com/package/google-closure-compiler should be up to date.

@MatrixFrog
Copy link
Contributor

@brad4d should have the latest info on releases.

@brad4d
Copy link
Contributor

brad4d commented Dec 6, 2017

FYI, I'm working on the December closure-compiler release this week, which includes updating this repo & corresponding npm.

@gaearon
Copy link
Author

gaearon commented Dec 6, 2017

Sweet, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants