Allow to disable renaming for the JS compiler #2707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 7, 2017
|
LGTM. I will bring this internally for testing. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2690.
I used the approach suggested by @ChadKillingsworth in #2690 (comment), but apply it to
GwtRunner(since I need this to be exposed in the JS version) as suggested by @anmonteiro in #2690 (comment).This adds a new
renamingoption to the JS version.It defaults to
true:When set to
false, it produces a build that doesn't minify variable or property names:It can only be set to
falseforSIMPLEmode. Doing so inADVANCEDmode throws:I need this option to move React builds completely to Google Closure Compiler. I’m happy to also include changes to expose this option to Java consumers, if you’d like, but I figured it’s best to send a PR with the minimal scope.
I’m sending this PR on the individual behalf not on company time. The code belongs to me.