Skip to content

Conversation

@matthew-0-1
Copy link

@matthew-0-1 matthew-0-1 requested a review from ralimi as a code owner August 31, 2023 21:15
@google-cla
Copy link

google-cla bot commented Aug 31, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@matthew-0-1
Copy link
Author

I noticed the actual cla/google workflow approval status is not public, while the error comment from google-cla bot is. This is not blocked on cla/google anymore.

@ralimi
Copy link
Collaborator

ralimi commented Sep 1, 2023

We have a requiement for this repository that all commits be signed, and merging is blocked on that.

Would it be possible to recreate this with a signed commit? Alternatively, I could patch in and submit if you would like.

@ralimi
Copy link
Collaborator

ralimi commented Sep 6, 2023

I'll go ahead and patch this in to move this forward. Appreciate the contribution!

ralimi added a commit that referenced this pull request Sep 6, 2023
This patches in #160 for submission.

Fixes #159.
ralimi added a commit that referenced this pull request Sep 6, 2023
This patches in #160 for submission.

Fixes #159.
@ralimi
Copy link
Collaborator

ralimi commented Sep 6, 2023

This was patched in as #171 . Thank you @matthew-0-1 for the contribution!

@ralimi ralimi closed this Sep 6, 2023
@matthew-0-1 matthew-0-1 deleted the allow-terminal-app branch December 12, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants