Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused ListThreads container method #1274

Merged
merged 1 commit into from
May 9, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions container/container.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,6 @@ type ContainerHandler interface {
// Returns the subcontainers of this container.
ListContainers(listType ListType) ([]info.ContainerReference, error)

// Returns the threads inside this container.
ListThreads(listType ListType) ([]int, error)

// Returns the processes inside this container.
ListProcesses(listType ListType) ([]int, error)

Expand Down
5 changes: 0 additions & 5 deletions container/docker/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -323,11 +323,6 @@ func (self *dockerContainerHandler) GetCgroupPath(resource string) (string, erro
return path, nil
}

func (self *dockerContainerHandler) ListThreads(listType container.ListType) ([]int, error) {
// TODO(vmarmol): Implement.
return nil, nil
}

func (self *dockerContainerHandler) GetContainerLabels() map[string]string {
return self.labels
}
Expand Down
5 changes: 0 additions & 5 deletions container/mock.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,6 @@ func (self *MockContainerHandler) ListContainers(listType ListType) ([]info.Cont
return args.Get(0).([]info.ContainerReference), args.Error(1)
}

func (self *MockContainerHandler) ListThreads(listType ListType) ([]int, error) {
args := self.Called(listType)
return args.Get(0).([]int), args.Error(1)
}

func (self *MockContainerHandler) ListProcesses(listType ListType) ([]int, error) {
args := self.Called(listType)
return args.Get(0).([]int), args.Error(1)
Expand Down
5 changes: 0 additions & 5 deletions container/raw/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -272,11 +272,6 @@ func (self *rawContainerHandler) ListContainers(listType container.ListType) ([]
return common.ListContainers(self.name, self.cgroupPaths, listType)
}

func (self *rawContainerHandler) ListThreads(listType container.ListType) ([]int, error) {
// TODO(vmarmol): Implement
return nil, nil
}

func (self *rawContainerHandler) ListProcesses(listType container.ListType) ([]int, error) {
return libcontainer.GetProcesses(self.cgroupManager)
}
Expand Down
5 changes: 0 additions & 5 deletions container/rkt/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -262,11 +262,6 @@ func (handler *rktContainerHandler) ListContainers(listType container.ListType)
return common.ListContainers(handler.name, handler.cgroupPaths, listType)
}

func (handler *rktContainerHandler) ListThreads(listType container.ListType) ([]int, error) {
// TODO(sjpotter): Implement? Not implemented with docker yet
return nil, nil
}

func (handler *rktContainerHandler) ListProcesses(listType container.ListType) ([]int, error) {
return libcontainer.GetProcesses(handler.cgroupManager)
}
Expand Down