Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused ListThreads container method #1274

Merged
merged 1 commit into from
May 9, 2016

Conversation

timstclair
Copy link
Contributor

No description provided.

@k8s-bot
Copy link
Collaborator

k8s-bot commented May 7, 2016

Jenkins GCE e2e

Build/test passed for commit 019bfae.

@vishh
Copy link
Contributor

vishh commented May 9, 2016

LGTM. Although a better change would be to implement it 😄

@timstclair
Copy link
Contributor Author

timstclair commented May 9, 2016

a better change would be to implement it

It's not just a matter of implementing it though. To be useful, it also needs to be wired through to all the endpoints: REST API, clients, and UI. If you think it's valuable we should open an issue for it, but as is I think it was just a confusing bit for new runtimes (rkt) to deal with.

@timstclair timstclair merged commit 8404284 into google:master May 9, 2016
@vishh
Copy link
Contributor

vishh commented May 9, 2016

Yeah. We haven't had an explicit request for it yet. So this PR makes
sense for now...

On Mon, May 9, 2016 at 11:59 AM, Tim St. Clair notifications@github.com
wrote:

a better change would be to implement it
It's not just a matter of implementing it though. To be useful, it also
needs to be wired through to all the endpoints: REST API, clients, and UI.
If you think it's valuable we should open an issue for it, but as is I
think it was just a confusing bit for new runtimes (rkt) to deal with.


You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
#1274 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants