Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests into separate functions that expect errors or not #123

Merged
merged 4 commits into from
Aug 3, 2020
Merged

Refactor tests into separate functions that expect errors or not #123

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e741f28
Divide tests from "expression_test.go" in two functions: one that exp…
rogerlucena Jul 29, 2020
6a00f51
Divide tests from "planner_test.go" in two functions: one that expect…
rogerlucena Jul 29, 2020
9274a64
Rename test function for clarity
rogerlucena Aug 3, 2020
766ee53
Make variable names more clear in "TestPlannerQuery"
rogerlucena Aug 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename test function for clarity
  • Loading branch information
@rogerlucena
rogerlucena committed Aug 3, 2020
commit 9274a64aa83d126c0088c49a01a8bdab10a3be60
4 changes: 2 additions & 2 deletions bql/semantic/expression_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ func mustBuildNodeFromStrings(nodeType, nodeID string) *node.Node {
return n
}

func TestNewEvaluator(t *testing.T) {
func TestEvaluatorEvaluate(t *testing.T) {
testTable := []struct {
id string
in []ConsumedElement
Expand Down Expand Up @@ -658,7 +658,7 @@ func TestNewEvaluator(t *testing.T) {
}
}

func TestNewEvaluatorError(t *testing.T) {
func TestEvaluatorEvaluateError(t *testing.T) {
testTable := []struct {
id string
in []ConsumedElement
Expand Down