Refactor tests into separate functions that expect errors or not #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ects success and another that expects error
…s success and another that expects error
thiagovas
approved these changes
Jul 30, 2020
Tati1701
reviewed
Jul 31, 2020
rbkloss
approved these changes
Aug 3, 2020
thiagovas
approved these changes
Aug 3, 2020
rbkloss
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For clarity, it is useful to not mix in the same test function cases for which it is expected an error and cases for which it is not.
Separating these cases into two different test functions makes the code cleaner and avoids the unnecessary use of more complicated
ifsinside the body of the test function. Also, it makes it easier to add new test cases in the future as it is simpler to realize where they belong to in the test file.Then, this PR comes to follow this guideline for two important test functions inside
expression_test.goandplanner_test.go.