-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for radio button getting unchecked after scroll (view recycled) in recycler view #1691
Conversation
…ups check api instead of radio button apis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if possible can you please write unit/android test (or you can create separate issue and when time permits it can be fixed), otherwise it looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aditya-07 I am working on writing a test to load questionnaires from JSON similar to how the catalog app works. Can you create an Issue to add UI tests for the different views that we have?
…ups check api instead of radio button apis (google#1691)
…ups check api instead of radio button apis (google#1691)
* Add Implementation guide management library module * Crashed Fixed in Quantity Input Widget (#1673) * Crashed Fixed in Quantity Input Widget * reverted unwanted changes * Spotless check applied * remove clear answer from factory Co-authored-by: omarismail <omarismail@google.com> * Fix review comments * Updated code to set the radio button in a radio group using radio groups check api instead of radio button apis (#1691) * Bump up SDC version to beta06 (#1694) * Follow up code health fixes of PR 1442 (#1631) * WIP PR feedback * spotless ran * added test cases for validation util * used fhirpathengine instance from fhir path expression evaluator * updated test cases name and convention * updated test cases name and their convention to look consistent Co-authored-by: Jing Tang <jingtang@google.com> * Disable leniency in DateFormat lib when converting date (#1687) * Fix Issue #1638: disable lenient check * add espresso test * add more tests per date field changed * Regenerate docs after SDC version bump (#1696) * Documentation Update : Changed the folder structure and did some other minor add-ons (#1662) * Create CODE_OF_CONDUCT.md * Delete CODE_OF_CONDUCT.md * Create Contributing.md * Delete contributing.md * Update README.md * Update README.md Co-authored-by: Omar Ismail <44980219+omarismail94@users.noreply.github.com> * Catlog app- Info grey box added in Calculated expression screen Behavior (#1679) * Scroll down the recyclerview to show the Add answer button. (#1666) * Scroll down the recyclerview to show the Add answer button. * Address review comments. * Address review comments. * Add flaky flag to retry * update gcloud components as well * remove version flag Co-authored-by: Santosh Pingle <spingle@google.com> Co-authored-by: Omar Ismail <44980219+omarismail94@users.noreply.github.com> Co-authored-by: omarismail <omarismail@google.com> * Enable "Next button" on paginated view when nested answer is chosen (#1684) Fix Issue #1677 * Add trailing line break. * Update buildSrc/src/main/kotlin/Releases.kt Co-authored-by: Jing Tang <jingtang@google.com> Co-authored-by: PallaviGanorkar <ganorkar@google.com> Co-authored-by: omarismail <omarismail@google.com> Co-authored-by: aditya-07 <adityakhajuria@google.com> Co-authored-by: Omar Ismail <44980219+omarismail94@users.noreply.github.com> Co-authored-by: aurangzaibumer <35099184+aurangzaibumer@users.noreply.github.com> Co-authored-by: Jing Tang <jingtang@google.com> Co-authored-by: Vanshaj Poonia <74147463+VanshajPoonia@users.noreply.github.com> Co-authored-by: santosh-pingle <86107848+santosh-pingle@users.noreply.github.com> Co-authored-by: Santosh Pingle <spingle@google.com>
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1683
Description
RadioButton
inRadioGroup
is sometimes causing theRadioButton
to not show appropriate state.RadioGroup
'scheck
api instead.Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Bug fix
Screenshots (if applicable)
Before the fix:
boolean_answer.webm
After the fix:
boolean_answer_fixed.webm
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.