Follow up code health fixes of PR 1442

[aurangzaibumer]

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1040

Description
The min/max validators are updated to use fhir path expressions. For date picker specifically, the widget doesn't allow input outside of the date range, this is a widget specific behavior. User can specify minimum and maximum date range using minValue and maxValue expression in questionnaire in order to prevent selecting the dates from outside the specified range. cqf-calculatedvalue expression is used to make the expression dynamic and use for some purpose as Age case (for example we can only registered a child that is born after 2020) (min value case).

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Feature

Screenshots (if applicable)

Checklist

• I have read and acknowledged the Code of conduct.
• I have read the Contributing page.
• I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
• I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
• I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
• I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
• I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

[jingtang10]

if this is ready for reveiw can you please mark this as such?

thanks - also, probably best for @omarismail94 to review since he reviewred the original pr.

[maimoonak]

Plz make test names a little more descriptive ... should like should return invalid value... why it should return invalid value?

[aurangzaibumer]

Comments are resolved. Please review.

[aurangzaibumer]

Review completed by @maimoonak . Assigned to @omarismail94 as per review process. thanks
cc @f-odhiambo

[jingtang10]

thanks @aurangzaibumer

[codecov]

Codecov Report

Merging #1631 (1fa7823) into master (cabc12a) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #1631      +/-   ##
============================================
- Coverage     32.73%   32.70%   -0.04%     
  Complexity      322      322              
============================================
  Files           151      151              
  Lines          5349     5348       -1     
  Branches        955      955              
============================================
- Hits           1751     1749       -2     
- Misses         3343     3344       +1     
  Partials        255      255              

Impacted Files	Coverage Δ
...d/fhir/datacapture/fhirpath/ExpressionEvaluator.kt	0.00% <0.00%> (ø)
...acapture/validation/MaxValueConstraintValidator.kt	75.00% <ø> (ø)
...roid/fhir/datacapture/validation/ValidationUtil.kt	14.28% <0.00%> (-19.05%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.