Repository navigation
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the clarity and conciseness of the tools reference documentation. By streamlining the main table to focus on high-level descriptions and guiding users to dedicated pages for detailed parameters, the documentation becomes easier to navigate and digest. A new test ensures this improved structure is maintained going forward. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request improves the readability of the tools reference documentation by removing parameter lists from the main table and adding a regression test to enforce this. The documentation change is clear and effective. The new test is a great addition for maintainability, but its implementation could be more robust to avoid silent failures. I've added a suggestion to improve the test's reliability.
| async function getAvailableToolsSection(): Promise<string> { | ||
| const toolsReference = await readFile(toolsReferencePath, 'utf8'); | ||
| const [, afterHeading = ''] = toolsReference.split('## Available tools'); | ||
| const [section = ''] = afterHeading.split('## Under the hood'); | ||
| return section; | ||
| } |
There was a problem hiding this comment.
The current implementation of getAvailableToolsSection is not robust. If the ## Available tools heading is missing or renamed, the test will silently pass because the destructuring assignment with a default value (= '') will hide the error. This can lead to a false sense of security. To make the test more reliable, it should explicitly check that the document sections are found and throw an error if they are not. This ensures the test fails loudly if the document structure changes unexpectedly.
async function getAvailableToolsSection(): Promise<string> {
const toolsReference = await readFile(toolsReferencePath, 'utf8');
const [, afterAvailableTools] = toolsReference.split('## Available tools');
if (afterAvailableTools === undefined) {
throw new Error('Could not find "## Available tools" heading in tools.md');
}
const [section] = afterAvailableTools.split('## Under the hood');
if (section === undefined) {
throw new Error('Could not find "## Under the hood" heading in tools.md');
}
return section;
}|
Hi maintainers — gentle consolidated follow-up for my open PRs in this repo (#21550 and #21241) to keep notifications low.\n\nCurrent status from my side:\n- #21550: docs-pr-check is still pending\n- #21241: CI appears green, currently waiting for maintainer review\n\nIf there is any extra contributor-side step needed (for docs-pr-check queue/approval or preferred next action), I can do it immediately. Thanks! |
|
/assign |
|
Hi, this issue is already fixed by a PR submitted by a contributor assigned to issue. Before creating future PRs, please make sure the issue is labeled as |
Summary
Testing
Fixes #21504