Repository navigation
feat(cli): expose /tools desc as explicit subcommand for discoverability - #21241
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the discoverability of the CLI's tool description feature by introducing a dedicated subcommand. This change makes the functionality more visible within the TUI, addressing a reported user experience issue. The implementation also includes refactoring of existing code to enhance maintainability, all while ensuring that previous methods of accessing this feature remain fully functional. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request exposes the tool description functionality as an explicit desc subcommand under /tools for better discoverability. The existing logic for listing tools has been refactored into a shared helper function, which is now used by both the new subcommand and the original /tools command action to maintain backward compatibility. A new unit test has been added to cover the new subcommand's functionality. The changes are logical and well-contained. I have reviewed the code and have not found any issues of high or critical severity.
|
Just a very light follow-up since this PR already has an approval. If anything is still needed before merge — a rebase, clarification, or adjusting the command naming to better fit repo conventions — I’m happy to handle it. |
…ity (google-gemini#21241) Co-authored-by: Coco Sheng <cocosheng@google.com> Co-authored-by: Gaurav <39389231+gsquared94@users.noreply.github.com>
…ity (google-gemini#21241) Co-authored-by: Coco Sheng <cocosheng@google.com> Co-authored-by: Gaurav <39389231+gsquared94@users.noreply.github.com>
…ity (google-gemini#21241) Co-authored-by: Coco Sheng <cocosheng@google.com> Co-authored-by: Gaurav <39389231+gsquared94@users.noreply.github.com>
…ity (google-gemini#21241) Co-authored-by: Coco Sheng <cocosheng@google.com> Co-authored-by: Gaurav <39389231+gsquared94@users.noreply.github.com>
…ity (google-gemini#21241) Co-authored-by: Coco Sheng <cocosheng@google.com> Co-authored-by: Gaurav <39389231+gsquared94@users.noreply.github.com>
…ity (#21241) Co-authored-by: Coco Sheng <cocosheng@google.com> Co-authored-by: Gaurav <39389231+gsquared94@users.noreply.github.com>
…ity (google-gemini#21241) Co-authored-by: Coco Sheng <cocosheng@google.com> Co-authored-by: Gaurav <39389231+gsquared94@users.noreply.github.com>
What
Add a visible
/tools descsubcommand so users can discover description mode directly in TUI command suggestions/help.Why
Issue #21214 reports that
/tools descbehavior exists but is not clearly visible/discoverable from TUI command UX.How
desc(alias:descriptions) as an explicit subcommand under/tools./tools descand/tools descriptions)./toolscommand description to point users to/tools desc.Testing
npm run build --workspace @google/gemini-cli-corenpm run test --workspace @google/gemini-cli -- src/ui/commands/toolsCommand.test.tsChecklist
Closes #21214