Build dm-tree against Python 3.13#123
Build dm-tree against Python 3.13#123copybara-service[bot] merged 1 commit intogoogle-deepmind:masterfrom
dm-tree against Python 3.13#123Conversation
|
@superbobry Take a look at this pull request which is concurrent with #120. |
|
@superbobry Trigger build once again please. It turns out that |
|
@superbobry Now, I have tested CI workflows beforehand in my fork (see this run as an example). It turns out that manual specification of link dependencies does not behave well. I have replaced Also, I have replaced In workflow declaration, I have replaced multiple per-architecture wheel building jobs with a single build matrix on target platform (operating system) and added py3.13 threaded (cp313t) although it is unclear to me whether it works correctly in free-threading mode. BTW The commit with |
|
@superbobry Trigger pipeline once again. It should be working now. |
|
Sorry for the silence and thank you for working on this @daskol. Trying now. |
|
Can you squash the commit please? Our import bot can't do that automatically yet, sadly. |
Squashed commit history is the following. - Bump `abseil-cpp` to fix building issue See abseil/abseil-cpp#1187 for details. - Build with vendored `abseil-cpp` by default - Forward number of jobs options as is - Actualize build matrix of Python interpreters - Bump `actions/upload-artifact` up to v4.6.0 - Build all wheels within single matrix job - Use `FetchContent` module to manage external dependencies
|
Sorry, this is probably because of "Allow edits and access to secrets by maintainers" checkbox but I'm not sure. I ticked it right now and squashed commits anyway. |
| - name: Install cibuildwheel | ||
| run: python -m pip install cibuildwheel==2.22.0 | ||
| - name: Build wheels | ||
| run: python -m cibuildwheel --output-dir wheelhouse |
There was a problem hiding this comment.
Use GitHub Action which can be managed by dependabot.
| - name: Install cibuildwheel | |
| run: python -m pip install cibuildwheel==2.22.0 | |
| - name: Build wheels | |
| run: python -m cibuildwheel --output-dir wheelhouse | |
| - name: Build wheels | |
| uses: pypa/cibuildwheel@v2.22 |
copybara-service
bot
merged commit c2c3660
into
google-deepmind:master
|
@superbobry Thank you for your time and effort! Are you planning on publishing new release on GitHub or PyPI? |
3 participants
Resolve #119.
The original issue is caused by missing include of
cstdintin gcc14 stdlib (see abseil/abseil-cpp#1187). In this PR,abseilis updated to the minimal version with the missing include. Other changes fix handling of-joption and revise build matrix.Also, it turns out that Ninja Multi-Config build is broken.