Skip to content

absl/strings/internal/str_format/extension.h: add missing <stdint.h> …#1187

Merged
copybara-service[bot] merged 1 commit intoabseil:masterfrom
trofi:fix-gcc-13-build
May 31, 2022
Merged

absl/strings/internal/str_format/extension.h: add missing <stdint.h> …#1187
copybara-service[bot] merged 1 commit intoabseil:masterfrom
trofi:fix-gcc-13-build

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented May 27, 2022

…include

Without the change absl-cpp build fails on this week's gcc-13 snapshot as:

/build/abseil-cpp/absl/strings/internal/str_format/extension.h:34:33: error: found ':' in nested-name-specifier, expected '::'
   34 | enum class FormatConversionChar : uint8_t;
      |                                 ^
      |                                 ::

…include

Without the change absl-cpp build fails on this week's gcc-13 snapshot as:

    /build/abseil-cpp/absl/strings/internal/str_format/extension.h:34:33: error: found ':' in nested-name-specifier, expected '::'
       34 | enum class FormatConversionChar : uint8_t;
          |                                 ^
          |                                 ::
@copybara-service copybara-service bot merged commit b957f0c into abseil:master May 31, 2022
@trofi trofi deleted the fix-gcc-13-build branch May 31, 2022 20:35
@iysheng

This comment was marked as spam.

martijneken added a commit to martijneken/proxy-wasm-cpp-host that referenced this pull request Aug 1, 2024
Pick up this fix: abseil/abseil-cpp#1187

Bump past Envoy to pick up another fix found in fuzz tests:
proxy-wasm#399 (comment)

Signed-off-by: Martijn Stevenson <mstevenson@google.com>
martijneken added a commit to proxy-wasm/proxy-wasm-cpp-host that referenced this pull request Aug 1, 2024
Bump Abseil to fix Linux build issues

Pick up this fix: abseil/abseil-cpp#1187

Bump past Envoy to pick up another fix found in fuzz tests:
#399 (comment)

Signed-off-by: Martijn Stevenson <mstevenson@google.com>
daskol added a commit to daskol/tree that referenced this pull request Jan 16, 2025
daskol added a commit to daskol/tree that referenced this pull request Jan 22, 2025
Squashed commit history is the following.

- Bump `abseil-cpp` to fix building issue

  See abseil/abseil-cpp#1187 for details.
- Build with vendored `abseil-cpp` by default
- Forward number of jobs options as is
- Actualize build matrix of Python interpreters
- Bump `actions/upload-artifact` up to v4.6.0
- Build all wheels within single matrix job
- Use `FetchContent` module to manage external dependencies
johnlanni pushed a commit to higress-group/proxy-wasm-cpp-host that referenced this pull request Jan 26, 2026
… behavior (proxy-wasm#434) (#11)

* fix: CI branch name master -> main (proxy-wasm#398)

Signed-off-by: Martijn Stevenson <mstevenson@google.com>

* fix: Bump Abseil to fix Linux build issues (proxy-wasm#400)

Bump Abseil to fix Linux build issues

Pick up this fix: abseil/abseil-cpp#1187

Bump past Envoy to pick up another fix found in fuzz tests:
proxy-wasm#399 (comment)

Signed-off-by: Martijn Stevenson <mstevenson@google.com>

* fix: Update cargo-raze -> crate_universe (proxy-wasm#399)

- Updated platforms for crate_universe compatibility
- Supports upgrade to wasmsign2
- Includes workaround for Windows path length issue

Signed-off-by: Martijn Stevenson <mstevenson@google.com>

* fix: Move from unavailable macos-11 to macos-13 (proxy-wasm#401)

See: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources

This does not fix proxy-wasm#384, but does resurface those errors.

Signed-off-by: Martijn Stevenson <mstevenson@google.com>

* chore: bump Bazel from 5.2.0 to 6.5.0 (proxy-wasm#402)

Bump Bazel from 5.2.0 to 6.5.0

This breaks the s390x build which relied on an external Docker image. I made some strides in fixing s390x, but it's not yet working. Deferred to proxy-wasm#405.

Signed-off-by: Martijn Stevenson <mstevenson@google.com>

* chore: bump rules_python and rules_fuzzing (proxy-wasm#404)

Upgrade rules_python (0.34.0) and rules_fuzzing (0.5.2)

This requires extracting WORKSPACE phases into more phases:
- dependencies -- py_repositories() and toolchains
- dependencies_python() -- pip_parse module loading
- dependencies_import() -- python/fuzzing/other deps

The new structure roughly matches Envoy WORKSPACE:
- envoy_dependencies()
- envoy_dependencies_extra() -- not needed here
- envoy_python_dependencies()
- envoy_dependency_imports()

Signed-off-by: Martijn Stevenson <mstevenson@google.com>

* Update CI to use Ubuntu 22.04 / clang 14 (proxy-wasm#408)

Signed-off-by: Martijn Stevenson <mstevenson@google.com>

* Update rules_rust to v0.42.1 (with Rust v1.77.2). (proxy-wasm#410)

* Update rules_rust
* Update rust and vendor
* rust_oom -> rg_oom
* Change rust version

---------

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

* Update wasmtime (v24.0.0) (proxy-wasm#406)

Removes Wasmtime + Windows CI because rules_rust has recently dropped Windows: https://github.com/bazelbuild/rules_rust/blob/main/docs/index.md#supported-platforms

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

* fix: Upgrade deprecated artifact upload/download handlers (proxy-wasm#415)

Seen on proxy-wasm#380 CI:

Error: This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v2`. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

Signed-off-by: Martijn Stevenson <mstevenson@google.com>

* bump wamr to 2.1.1 and able to consume precompiled content (proxy-wasm#380)

- skip leading paddings in .aot section

Signed-off-by: liang.he@intel.com <liang.he@intel.com>

* compdb add the compdb support to the proxy_wasm_cpp_host (proxy-wasm#419)

* compdb add the compdb support to the proxy_wasm_cpp_host

Signed-off-by: wangbaiping <wbphub@gmail.com>

* Fix references to prefix_wasm_api (proxy-wasm#420)

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

* feat(go-sdk): add wasi hostcalls used by the Go SDK (proxy-wasm#427)

The full Go sdk imports hostcalls not currently exported to the wasm
module, making the wasm module fail on instantiation. Per discussion
with the Go core maintainers, these functions do not need to be
implemented, but they must be present.

Signed-off-by: Matt Leon <mattleon@google.com>

* chore: workflow runner fixes (proxy-wasm#436)

Assorted changes to get workflows working again:

- Update format workflows to use ubuntu-22.04
- Update windows-2019 to windows-2022 and add a missing <string> include needed to
  build with that
- Enable manual triggering of workflows

Fixes proxy-wasm#435

---------

Signed-off-by: Michael Warres <mpw@google.com>

* feat: add knob to customise on{Request,Response}Headers StopIteration behavior (proxy-wasm#434)

Add protected ContextBase::allow_on_headers_stop_iteration_ field that can be used by host implementations to control whether or not ContextBase propagates FilterHeaderStatus::StopIteration returned by onRequestHeaders() or onResponseHeaders() without modification.

Follow-on envoyproxy/envoy#40213 adds an option in Envoy WasmFilter PluginConfig that sets the value of this field.

For details, see [Envoy Wasm / Proxy-Wasm support for FilterHeadersStatus::StopIteration](https://docs.google.com/document/d/1Whd1C0k-H2NHrPOmlAqqauFz6ObSTP017juJIYyciB0/edit?usp=sharing). This PR is one part of implementing [Option B: WasmFilter config knob](https://docs.google.com/document/d/1Whd1C0k-H2NHrPOmlAqqauFz6ObSTP017juJIYyciB0/edit?tab=t.0#bookmark=id.5wxldlapsp54).

Note that default behavior of proxy-wasm-cpp-host and ContextBase is unchanged.

---------

Signed-off-by: Michael Warres <mpw@google.com>

---------

Signed-off-by: Martijn Stevenson <mstevenson@google.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: liang.he@intel.com <liang.he@intel.com>
Signed-off-by: wangbaiping <wbphub@gmail.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Michael Warres <mpw@google.com>
Co-authored-by: martijneken <mstevenson@google.com>
Co-authored-by: Keith Mattix II <keithmattix2@gmail.com>
Co-authored-by: Keith Mattix II <keithmattix@microsoft.com>
Co-authored-by: liang.he <liang.he@intel.com>
Co-authored-by: code <wbphub@gmail.com>
Co-authored-by: Matt Leon <ml@mattleon.com>
Co-authored-by: Michael Warres <mpw@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants