Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for Python API #278

Merged
merged 11 commits into from
Feb 13, 2024
Merged

Fixes for Python API #278

merged 11 commits into from
Feb 13, 2024

Conversation

thowell
Copy link
Collaborator

@thowell thowell commented Feb 6, 2024 •
edited
Loading

  • Python module looks in build directory for task models
  • Change filepath for quadruped task_flat to build directory to fix Python test
  • Minor update to README mentioning to first build MJPC
  • Add .eggs to gitignore
  • Change filepath to build for agent_test.py since Patches #256

The change to the build directory enables us to utilize "patches" (#256) for task models without rewriting the python/setup.py.

@thowell thowell requested a review from erez-tom February 6, 2024 04:34
@thowell
Copy link
Collaborator Author

thowell commented Feb 9, 2024

@nimrod-gileadi is this the correct way to check that the build exists and provide the user with an informative error if it is missing?

@thowell thowell mentioned this pull request Feb 9, 2024
Closed
22 tasks
@thowell thowell mentioned this pull request Feb 12, 2024
Merged
@erez-tom erez-tom merged commit 4384ef0 into google-deepmind:main Feb 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erez-tom erez-tom erez-tom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thowell @erez-tom