[bot] Merge master/636fa462 into rel/dev#1515
Merged
yenkins-admin merged 2 commits intorel/devfrom Apr 7, 2026
Merged
Conversation
The WASM converter functions declarativeVisualisationToYaml and declarativeDashboardToYaml require an entities array as their first argument. The Python wrappers were only passing the declarative dict, which the WASM received as the entities param, leaving the actual object undefined — causing "cannot read property 'content' of undefined" for every visualization and dashboard. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> JIRA: DX-326 risk: low
fix: pass entities arg to WASM visualization/dashboard converters
yenkins-admin
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1515 +/- ##
===========================================
+ Coverage 78.13% 78.18% +0.04%
===========================================
Files 228 228
Lines 14926 14928 +2
===========================================
+ Hits 11662 11671 +9
+ Misses 3264 3257 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to 636fa46 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/24070456725).