Skip to content

fix: pass entities arg to WASM visualization/dashboard converters#1514

Merged
jaceksan merged 1 commit intomasterfrom
jacek/working
Apr 7, 2026
Merged

fix: pass entities arg to WASM visualization/dashboard converters#1514
jaceksan merged 1 commit intomasterfrom
jacek/working

Conversation

@jaceksan
Copy link
Copy Markdown
Contributor

@jaceksan jaceksan commented Apr 7, 2026

Summary

declarative_visualization_to_aac and declarative_dashboard_to_aac were passing only the declarative dict to the WASM converters, but the TS functions declarativeVisualisationToYaml(entities, visualisation) and declarativeDashboardToYaml(entities, dashboard) expect entities as the first argument. The dict was received as entities, leaving the actual object undefined — causing "cannot read property 'content' of undefined" for every visualization and dashboard during get_and_store_aac_workspace.

Test plan

  • New unit tests for declarative→AAC visualization conversion (fixture round-trip and inline)
  • New integration test: store_aac_workspace_to_disk with visualizations, then reload
  • New integration test: full fixture load→store→reload round-trip
  • All 23 AAC tests pass

Co-authored-by: Claude Opus 4.6 (1M context) noreply@anthropic.com
JIRA: DX-326
risk: low

The WASM converter functions declarativeVisualisationToYaml and
declarativeDashboardToYaml require an entities array as their first
argument. The Python wrappers were only passing the declarative dict,
which the WASM received as the entities param, leaving the actual
object undefined — causing "cannot read property 'content' of undefined"
for every visualization and dashboard.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
JIRA: DX-326
risk: low
@jaceksan jaceksan requested review from hkad98, lupko and pcerny as code owners April 7, 2026 07:43
@jaceksan jaceksan enabled auto-merge April 7, 2026 07:46
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.18%. Comparing base (d6a7ef4) to head (48dc249).

Files with missing lines Patch % Lines
...data-sdk/src/gooddata_sdk/catalog/workspace/aac.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1514      +/-   ##
==========================================
+ Coverage   78.13%   78.18%   +0.04%     
==========================================
  Files         228      228              
  Lines       14926    14928       +2     
==========================================
+ Hits        11662    11671       +9     
+ Misses       3264     3257       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jaceksan jaceksan merged commit 636fa46 into master Apr 7, 2026
12 of 13 checks passed
@jaceksan jaceksan deleted the jacek/working branch April 7, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants