Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear up language and remove duplicate content #1202

Merged
merged 3 commits into from
Apr 30, 2019
Merged

Clear up language and remove duplicate content #1202

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40f9f96
Clear up language and remove duplicate content
Apr 30, 2019
c13c9f4
Merge branch 'master' into typos
Apr 30, 2019
3b84fb5
Merge branch 'master' into typos
arschles Apr 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Clear up language and remove duplicate content
  • Loading branch information
Scott Lee committed Apr 30, 2019
commit 40f9f96aefa80e0e55da619c3d9ce30a4e3f2362
3 changes: 1 addition & 2 deletions docs/content/faq.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,5 +74,4 @@ To try out tracing with Jaeger, do the following:
- Run the walkthrough tutorial
- Open `http://localhost:16686/search`

Observability is not a hard requirement for the Athens proxy. So, if the infrastructure is not properly set up, they will fail with an information log. For eg. if Jaeger is not running / if the wrong URL to the exporter is provided, proxy will continue to run. However, it will not collect any traces or metrics (when the exporter backend is unavailable).

Observability is not a hard requirement for the Athens proxy. So, if the infrastructure is not properly set up, it will fail with an information log. For example, if Jaeger is not running or if the wrong URL to the exporter is provided, the proxy will continue to run. However, it will not collect any traces or metrics while the exporter backend is unavailable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ this!

6 changes: 0 additions & 6 deletions docs/content/install/install-on-kubernetes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,6 @@ $ helm install gomods/athens-proxy -n athens --namespace athens

This will deploy a single Athens instance in the `default` namespace with `disk` storage enabled. Additionally, a `ClusterIP` service will be created.

By default, the chart will install Athens with a replica count of 1. To change this, change the `replicaCount` value:

```console
helm install gomods/athens-proxy -n athens --namespace athens --set replicaCount=3
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scottilee I should know this by now, but is this command somewhere else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look at the screenshot I posted they're right above and below each other. Repasting the screenshot:
Screen Shot 2019-04-29 at 6 16 24 PM

I figured it was an "advanced" command so I left it in that section instead of the previous one.

## Advanced Configuration

### Replicas
Expand Down