Clear up language and remove duplicate content #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manugupt1
approved these changes
Apr 30, 2019
arschles
approved these changes
Apr 30, 2019
There was a problem hiding this comment.
@scottilee sorry for the delay here, but this looks great 🚀 
. I don't want to delay this PR on my question on the helm install command, so I'm going to merge. Can you respond in the thread after the PR is merged, or tell me in slack?
| ```console | ||
| helm install gomods/athens-proxy -n athens --namespace athens --set replicaCount=3 | ||
| ``` | ||
|
|
There was a problem hiding this comment.
@scottilee I should know this by now, but is this command somewhere else?
There was a problem hiding this comment.
If you look at the screenshot I posted they're right above and below each other. Repasting the screenshot:
I figured it was an "advanced" command so I left it in that section instead of the previous one.
| @@ -74,5 +74,4 @@ To try out tracing with Jaeger, do the following: | |||
| - Run the walkthrough tutorial | |||
| - Open `http://localhost:16686/search` | |||
|
|
|||
| Observability is not a hard requirement for the Athens proxy. So, if the infrastructure is not properly set up, they will fail with an information log. For eg. if Jaeger is not running / if the wrong URL to the exporter is provided, proxy will continue to run. However, it will not collect any traces or metrics (when the exporter backend is unavailable). | |||
|
|
|||
| Observability is not a hard requirement for the Athens proxy. So, if the infrastructure is not properly set up, it will fail with an information log. For example, if Jaeger is not running or if the wrong URL to the exporter is provided, the proxy will continue to run. However, it will not collect any traces or metrics while the exporter backend is unavailable. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
Describe the issue you have been trying to solve.
How is the fix applied?
Mention briefly how you have applied the fix.
Mention the issue number it fixes or add the details of the changes if it doesn't have a specific issue.
Fixes #