ci: add image build #12573
Closed
ci: add image build #12573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
morremeyer
force-pushed
the
ci/add-image-build
branch
from
dec7323
to
03b1f2a
Compare
morremeyer
force-pushed
the
ci/add-image-build
branch
from
03b1f2a
to
5f70dc1
Compare
|
This is now ready for review, no more force-pushes here. |
|
@morremeyer thanks for this. I just wanted to chime in and say that I have seen this, and it looks good. I just need to think about this, as I'm a little stretched for time, and 1) A setup like this will eventually have to be updated/fixed when GitHub changes its API etc. and 2) This will open the gate for people wanting a more advanced |
8 tasks
What is the name of the repository to pull? |
|
Sorry for the delay; I'm going to test and complete this in #12734. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a Docker image build running in GitHub actions for
linux/amd64andlinux/arm64images.The build runs for every PR that changes either the workflow or the Dockerfile to verify the image still can be built correctly, but does not push the image for these runs.
For every tag, the images are built and pushed to the GitHub OCI registry.
Resolves #10760.
Testing
I have run tests with a slightly modified version (to enable testing) in my fork, see the test-add-image-build branch.
This builds the image with this workflow and results in the package being pushed to https://github.com/morremeyer/hugo/pkgs/container/hugo.
Continuous testing
I am aware of #8700 (comment) and happy to add automated testing of the images if there is a clear requirement for what should be tested.
However, as with the Dockerfile being a convenience, the same could also be applied to the resulting image in terms of guarantees.