-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create and publish official Docker images #10760
Comments
/cc ... @klakegg |
Hi @klakegg, may I kindly remember you regarding this issue? |
Have a look here: https://discourse.gohugo.io/t/the-up-to-date-hugo-docker-images/43293 I think we should make this one (or another) default since @klakegg has not touched the repo since end of last year + also in the past (based on the issues/PRs there) the communication wasnt the very best. Likely some private matters - So why not move the docker stuff into a more community handled repo? |
@fsmeier Thanks for pointing this thread out to me. In my opinion it would be best if something along the lines of a CI/CD is directly implemented within the Additionally, using a CI/CD, one could use something with a more "official" name, e.g. hub.docker.com/r/hugo or similiar. However, the question would be if hugo wants to support/provide a docker image directly. |
As this issue is now link from other ones, I want to take the oppertunity to summarize the current state: As far as I know, klakegg's repository is/was the one, which was references as the most official repository. Some have several thousand pulls. Also GitLab itself (https://gitlab.com/gitlab-ci-utils/docker-hugo) built its own image to use within their CI/CD. The repository which would be the "offical" one regarding the name (https://hub.docker.com/r/gohugoio/hugo) has also over 6k pulls but is currently not maintained. As you can see, the repositories are cluttered over the web and several companies/ppl are creating ones so there is definitely a need for it. For myself, I also like to use an image in my CI/CD as it saves me from the trouble of always downloading the binary and installing it. The image is cached by k8s (or whatever cluster you're using), but the download would be not by default. In the end, I would strongly recommend to create an official repository (using gohugoio/hugo in the best case). If needed, I can provide help to set up a CI. Currently, I'm only using GitLab's CI, however, familiarize myself with GitHub Actions should be possible :) |
an earlier PR is at #8700 |
It's currently mostly a "don't have time", which you could also blame on priorities. |
Thanks for your answer @bep. Is this something you would accept a merge request for, or would you prefer to do it on your own, maybe because you have some restrictions/requirements in mind? |
Yea, this project is a handful of maintainers more or less active, and when one of those (e.g. klakegg) gets other priorities (e.g. life/work), this happens. To ask a more practical question -- how does Docker images published to GitHub work vs. Docker hub? I say this because that would simplify "things". I'm trying to avoid having to maintain yet another or on yet another host. |
@bep Publishing should work in the same way and technically there is no much difference than to use another domain to push the image to. For both options there are examples in GitHub's documentation on how to implement this workflow using GitHub Actions: https://docs.github.com/en/actions/publishing-packages/publishing-docker-images However, using the Docker Hub would have some significant advantages: If using GitHub Packages, either the docker daemon needs to be reconfigured to use ghcr.io as an additional registry, or one needs to run Additionally, Google shows the Docker Hub at the very first position and there is already an entry for gohugoio/hugo. |
Hi @Flauschbaellchen, It seems that this issue has not been improved yet. Before the official release of the docker image, I created an automated GitHub CICD process to fetch the latest version daily, compile it into a docker image, and push it to docker hub. I currently offer versions after v0.115.4. Although the images provided are not as rich as klakegg/hugo, I believe they should be sufficient for use. If there are any inconveniences or requirements, feel free to provide me with a PR. Hugo's release version after v0.115.4 can be accessed using the image I provide at jafee201153/hugo. |
@leoli0605 I don't think it's a good idea to have just another docker repository for hugo. I think it just takes a bit more time and some discussion what would be the best way so we don't need to change something else only some months in the future. |
I do the development of my blog using a Hashicorp product called Vagrant. Think of Vagrant like Docker, but for VMs (e.g., declarative file with all dependencies, easy to pass around to different machines to have the same development environment). If you're not aware, Hashicorp recently changed all of their products to a Business Source License (BSL). This has mostly upset the Terraform community, but it affects all Hashicorp products. Here is the commit with the change to Vagrant's license. I'd like to start doing development of my blog in Docker, but found the https://hub.docker.com/r/gohugoio/hugo image hasn't been updated in years. Doing some searching, I found this issue. I'm all in favor of having an official Docker image, I just think Hugo should advertise which image that is. It's not clear if that is |
@Flauschbaellchen I completely agree with your point that continuous deployment of updates on DockerHub by the official is the best practice. However, it seems that neither the official nor |
hi all, |
Hey @bep Can we keep this discussion ongoing? As you see, others are happily creating new repositories, increasing the chaos already present 🙈 |
I just stumbled upon this since I was confused that the most recent image on https://hub.docker.com/r/gohugoio/hugo is 6 years old. I'm one of the maintainers for https://github.com/community-tooling, we do maintain a set of OCI images in the https://github.com/community-tooling/oci-images repository, these are built 100% automated and published to GitHub Packages. If there's interest here, I can open a PR with a GitHub Actions workflow that will automatically build and publish new OCI/Docker images for every release. |
Just want to add this seems like such an obvious win, as others have shown once its up and running it shouldn't take make much to keep going. Not only that the docker pulls are a much more relevant sign than the github requests. @Flauschbaellchen @morremeyer please keep trying. |
I opened #12573, which adds a Docker image build that is published to the GitHub packages registry. |
Sorry to bump a closed issue. Where are these images and is there documentation for using them? I don't see a package on GitHub, and the DockerHub image is still 6 years old. |
@loganmarchione see #12753 ... we had some issues with the GitHub actions workflow ... We think that should be resolved, but I need to do another patch release (tomorrow); I will add a line or two to the documentation when that's done. |
Reopen this, see #12753 |
The latest docker image on https://hub.docker.com/r/klakegg/hugo is 0.111.3 which was pushed 2 weeks ago but was released on 12 March.
When searching for any higher version like 0.112.0 or 0.114.0 no images/tags can be found.
Same issue as #10324 reported some months ago.
The text was updated successfully, but these errors were encountered: