Skip to content

NewProductService should return the Service interface, not the private service type #3323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

NewProductService should return the Service interface, not the private service type #3323

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8415e53
NewProductService should return the Service interface, not the privat…
kucukaslan Sep 14, 2025
67cb4c7
update the godoc
kucukaslan Sep 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hexagonal/service/logic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ type service struct {
productRepo domain.Repository
}

// NewProductService a service struct that attaches to a repository via the Repository interface
func NewProductService(productRepo domain.Repository) *service {
// NewProductService returns a domain.Service backed by the provided domain.Repository.
func NewProductService(productRepo domain.Repository) domain.Service {
return &service{productRepo: productRepo}
}

Expand Down