Fix issue with incomplete property overrides in C# sourcegen #98396
+265
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash in several generators, preventing compilation through CS8785.
To filter read-only properties, we currently check if the property is read-only (duh), or is its set method is init-only. In reality, we cannot take for granted the fact a set method is available to check, even when the property is not read-only. This is because C# allows the following.
Since we assume we have a set method to check, we're raising an NRE when checking for the init-only flag. To fix this, we're now recursing on the overridden property if it makes sense.
Cheers ✌️