Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect depth comparison used to calculate volumetric fog shadowing #98226

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Fix incorrect depth comparison used to calculate volumetric fog shadowing #98226

merged 1 commit into from
Oct 21, 2024

Conversation

m-pranav-r
Copy link
Contributor

@m-pranav-r m-pranav-r commented Oct 16, 2024 •
edited
Loading

Fixes #95785. Added the depth reversal logic that was necessary for proper shadow tests with omnidirectional lights active in fog volumes. #88328 seems to be the one that broke it for now.

Pictures for comparison:

Before:
Desktop Screenshot 2024 10 16 - 15 02 28 70
Desktop Screenshot 2024 10 16 - 15 02 43 85

After:
Desktop Screenshot 2024 10 16 - 15 03 11 08
Desktop Screenshot 2024 10 16 - 15 03 21 17

@m-pranav-r m-pranav-r requested a review from a team as a code owner October 16, 2024 09:41
@AThousandShips AThousandShips added bug topic:rendering topic:3d cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Oct 16, 2024
@AThousandShips AThousandShips added this to the 4.4 milestone Oct 16, 2024
clayjohn
clayjohn approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work tracking that down! I'm surprised we are still running into regressions from the reverse-z change. But I'm thankful that you fixed this one.

@Repiteo Repiteo merged commit c145e85 into godotengine:master Oct 21, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 21, 2024

Thanks! Congratulations on your first contribution!

@Spartan322 Spartan322 mentioned this pull request Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:rendering topic:3d
Projects
None yet
Milestone
4.4
4 participants
@m-pranav-r @Repiteo @clayjohn @AThousandShips