Add unit tests for AnimationLibrary. #98020
Conversation
Covered functions: is_valid_animation_name, is_valid_library_name, validate_library_name, add_animation, remove_animation, rename_animation, has_animation, get_animation and get_animation_list. Covered signals: animation_added, animation_removed, animation_renamed and animation_changed.
|
Please put the formatting fixes in a separate commit, as they are unrelated to the tests |
It's already in a separate commit? |
|
*separate PR sorry Should probably be handled in a larger set of fixes improving various cases, if it's considered appropriate, see: |
EAinsley
force-pushed
the
animation-library-tests
branch
from
ffbdb64
to
0036f95
Compare
Thank you for the information. I was just about to say that I felt the fix is too small to be a pr. |
Should I squash the commit instead, since I have already fixed it when writing the test cases for that class? |
I'm working on adding the tests for AnimationPlayer, and noticed we don't have tests for AnimationLibrary yet. Just wrote one when I'm still studying the code.