-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TRACKER] Typos and UI Paper Cuts #91521
Comments
This comment was marked as resolved.
This comment was marked as resolved.
Grammar issues:
Likely intended to be "...representing a GLTF bufferView...":
Edit: Addressed in #95578. |
Many uses of
|
There are a lot of string concatenations that should be changed to |
Not sure if there is an easy way to find all these occurrences across the repository. But indeed these are the kind of changes that shouldn't be done as tiny PRs that change 1 place, but rather one large PR that fixes this on a broader scale, so it makes sense to do it together with tiny typo fixes like those listed here. |
One thing to search for would be: |
That would be too laborious. It would be better if someone just fix a little bit when they saw those code while working on a big commit and commit them alongside. |
If it touches the area sure, but only then, but these changes are best handled systematically |
As per godotengine/godot-proposals#9648, this issue tracks tiny issues which can easily be fixed and are not opinionated changes. This includes:
It does NOT include any functional changes, such as refactoring or reordering code.
Purpose of tracking these is NOT for users to make PRs for fixing them directly, but rather:
A task list is used to keep track of how many issues there are, but you can simply remove the bullet points when done instead of checking them, to keep this tracker clean and re-usable.
Typos
core/object/script_language.cpp
characacteristics
->characteristics
editor/plugins/visual_shader_editor_plugin.cpp
at_setup_node
functioncamelCase
should besnake_case
scene/gui/code_edit.cpp
all_ocurence
->all_occurrences
(local variable)doc/classes/SceneMultiplayer.xml
SceneMultiplayer
#97607Functional changes
core/string/translation.cpp
inside ofTranslationServer::setup()
ProjectSettings::get_singleton()->set_custom_property_info(PropertyInfo(Variant::STRING, "internationalization/locale/test", PROPERTY_HINT_LOCALE_ID, ""));
Maintainers are free to edit this issue to add to the list or change wording.
Other contributors are welcome to write comments and they'll be taken into account.
The text was updated successfully, but these errors were encountered: