Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RenderingDevice: Use correct layer count for Cubemaps during boundary checks #94708

Merged
merged 1 commit into from
Jul 24, 2024
Merged

RenderingDevice: Use correct layer count for Cubemaps during boundary checks #94708

merged 1 commit into from
Jul 24, 2024

Conversation

BlueCube3310
Copy link
Contributor

Follow-up to #94656.

Removes the code which used to incorrectly multiply the cubemap layer count by 6 for boundary checks.

@BlueCube3310 BlueCube3310 requested a review from a team as a code owner July 24, 2024 18:31
@akien-mga akien-mga added this to the 4.3 milestone Jul 24, 2024
clayjohn
clayjohn approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you

@akien-mga akien-mga merged commit 2f2d1a7 into godotengine:master Jul 24, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@BlueCube3310 BlueCube3310 deleted the rd-cubemap-layer-amount-correct branch July 25, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug topic:rendering
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@BlueCube3310 @akien-mga @clayjohn