-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash when adding scenes with a group to the level scene #94450
Conversation
It does not fix the crash, because you did not delete the Also you can just do an early return at the beginning: if (!scene_root_node) {
return;
} |
Oops, messed up which lines to stage when committing, that extra line wasn't there when I was testing it obviously :D |
Please squash your commits into one, see here |
I was going to do that, then I read that you can just set github to do it for you on all PRs.. so I'd hoped that was the case |
We don't use GitHub's squash and merge feature on the main Godot repository, since it loses the merge commit in the process. We prefer keeping the merge commit to make the Git history more self-documented (even if that makes it longer when not using the |
Thanks! |
Fixes #94274