[Android] Fix the issue causing the logo to not show when using the compatibility renderer
#93891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
force-pushed
the
fix_logo_not_showing_for_gles3
branch
from
9e3e73f
to
637f4a1
Compare
@adamscott I switched it to an enum. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delaying showing the logo by 1 frame so that it doesn't run in the same frame as the setup logic resolves the issue.
To do so, the logo logic is moved out of
Main::setup2(...)into its ownMain::setup_boot_logo()method. By default, that method is invoked automatically byMain::setup2(...), but on Android platforms, the default behavior is disabled and theMain::setup_boot_logo()is invoked in the next frame.Fixes #92966