Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Physics interpolation: Fix 2D skinning #93368

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Physics interpolation: Fix 2D skinning #93368

merged 1 commit into from
Jun 20, 2024

Conversation

rburing
Copy link
Member

@rburing rburing commented Jun 19, 2024

@rburing rburing added this to the 4.3 milestone Jun 19, 2024
@rburing rburing requested a review from a team as a code owner June 19, 2024 20:59
@rburing rburing requested a review from lawnjelly June 19, 2024 20:59
lawnjelly
lawnjelly approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@lawnjelly lawnjelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is good, it looks like mostly a straight port fixes the issues in 4.x too, and this keeps the existing notification stack working.

AThousandShips
AThousandShips approved these changes Jun 20, 2024
View reviewed changes
scene/2d/skeleton_2d.cpp Show resolved Hide resolved
@rburing @lawnjelly
Physics interpolation: Fix 2D skinning
6d35dcf 
Co-authored-by: lawnjelly <lawnjelly@gmail.com>
@akien-mga akien-mga added the bug label Jun 20, 2024
@akien-mga akien-mga merged commit ff9c633 into godotengine:master Jun 20, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@rburing rburing deleted the fti_skinning branch July 7, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lawnjelly lawnjelly lawnjelly approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
bug topic:rendering topic:2d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Physics interpolation doesn't interpolate Skeleton2D animation correctly, resulting in wobbly visuals
4 participants
@rburing @akien-mga @lawnjelly @AThousandShips