Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to default theme for variation items #91793

Merged
merged 1 commit into from
May 11, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented May 10, 2024

Fixes #91738

@KoBeWi KoBeWi force-pushed the a_theme_has_many_variations branch from 8cc27b7 to d7bedcd Compare May 10, 2024 11:16
@YeldhamDev
Copy link
Member

This PR makes the editor show defaults elements from its parents:

Pre 32b0834 This PR
Screenshot_20240510_103222 Screenshot_20240510_103125

@KoBeWi
Copy link
Member Author

KoBeWi commented May 10, 2024

The values are correct, it just shows every theme property:
image
The list is still fetched from ThemeDB.

@akien-mga akien-mga merged commit 768bd0e into godotengine:master May 11, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the a_theme_has_many_variations branch May 11, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default theme item variations aren't shown in the theme editor anymore.
3 participants