Skip rendering sky if viewport is set to transparent background #91642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
reviewed
May 7, 2024
There was a problem hiding this comment.
We may want to disable updating the radiance maps when the reflection source is not background.
Right now, this will continue to update the radiance maps as long as the background mode is set to sky, even if the reflection mode is set to custom color.
The current logic for updating the radiance maps is:
if (draw_sky || draw_sky_fog_only || environment_get_reflection_source(p_render_data->environment) == RS::ENV_REFLECTION_SOURCE_SKY || environment_get_ambient_source(p_render_data->environment) == RS::ENV_AMBIENT_SOURCE_SKY) {
BastiaanOlij
force-pushed
the
fix_transparent_sky
branch
from
2976c10
to
fec5d57
Compare
|
@clayjohn I've changed the logic so The radiance map will thus not be updated when the background is transparent unless:
Hopefully that will give the right level of control. |
BastiaanOlij
force-pushed
the
fix_transparent_sky
branch
from
fec5d57
to
6efaaec
Compare
BastiaanOlij
commented
May 13, 2024
servers/rendering/renderer_rd/forward_clustered/render_forward_clustered.cpp
Show resolved
Hide resolved
|
Thanks! |
This was referenced Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Godot 3, if we set the viewport to have a transparent background we would clear the environment used for that viewport skipping rendering things like the sky.
In Godot 4 we no longer do this as many settings in the environment still apply. However as we render the sky with alpha 0 (at least on Vulkan), the user was blissfully unaware the sky was being rendered and this took up a fair bit of resources.
This is because we're (ab)using the alpha for sub surface scattering.
The compatibility renderer doesn't do this and you do see the sky, which at least informs the user they may wish to reconfigure the background. This is something we may change in the future but we'll do that as a separate thing.
This PR resolves this issue by skipping rendering the sky if our viewport is set to transparent. We do still update the radiance map so you can have the sky contribute to ambient lighting.
Test project:
test-transparent-sky.zip