-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix selecting root when opening scene. #91435
Fix selecting root when opening scene. #91435
Conversation
There's another PR that also says that will fix the issue: #91430 |
Even if the other one is merged I think this should still me merged because of the issue I showed |
I tested this PR and everything seems to work fine except when tabbing between scenes without changing the selection. I think it's maybe another side effect of calling After the first load of a scene, the selection is restored correctly, but if I switch to another scene (another tab) and go back to the first scene, only one node is selected. Exemple: Before (version 4.2.1): |
587ee0b
to
0ab5d37
Compare
Thanks! |
This broke when the `node_selected` connection was removed in godotengine#91435. Here it's returned, but the emit is removed from `_node_removed`. That preserves the earlier fix while allowing nodes to be reselected.
This broke when the `node_selected` connection was removed in godotengine#91435. Here it's returned, but the emit is removed from `_node_removed`. That preserves the earlier fix while allowing nodes to be reselected.
This broke when the `node_selected` connection was removed in godotengine#91435. Here it's returned, but the emit is removed from `_node_removed`. That preserves the earlier fix while allowing nodes to be reselected.
This broke when the `node_selected` connection was removed in godotengine#91435. Here it's returned, but the emit is removed from `_node_removed`. That preserves the earlier fix while allowing nodes to be reselected.
This broke when the `node_selected` connection was removed in godotengine#91435. Here it's returned, but the emit is removed from `_node_removed`. That preserves the earlier fix while allowing nodes to be reselected.
Fixes #91411
This part was literaly pushing the root to be edited whenever loaded. This made a lot of issues and my modifications to
edit_current
and selection made it more visible.This was removed in #80517 during restoration of scenes because those problems became too apparent there but kept it for normal loading. The fact is some of those bugs can be reproduced with simple loading like the theme one
output.mp4
Here I removed it untirely but I'm wondering if it is a feature that if nothing is selected when opening the scene it automatically selects the root if so then I can update the PR to make it so in a non problematic way.