Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in shader breaking gles3 #91426

Merged
merged 1 commit into from
May 2, 2024
Merged

Fix typo in shader breaking gles3 #91426

merged 1 commit into from
May 2, 2024

Conversation

semensanyok
Copy link
Contributor

caused by e410643

ERROR: SceneShaderGLES3: Fragment shader compilation failed:
0(1142) : error C0116: #endif should not have arguments
0(1860) : error C0116: #endif should not have arguments

   at: _display_error_with_code (drivers\gles3\shader_gles3.cpp:253)
ERROR: Method/function failed.
   at: ShaderGLES3::_compile_specialization (drivers\gles3\shader_gles3.cpp:395)

@semensanyok semensanyok requested a review from a team as a code owner May 1, 2024 22:35
semensanyok referenced this pull request May 1, 2024
@QbieShay
reverted naming to premul alpha (no T)
e410643 
Initially 3d had premulT alpha as a keyword.
Since Canvas item uses mixed premul and premult as keywords,
3D is changed as well to keep consistency with 2D.
Unfortunately this keeps inconsistency with the internal ENUM.
@Rubonnek Rubonnek added this to the 4.3 milestone May 1, 2024
@fire fire changed the title fix typo in e41064388e67cc9bec320ee467757089b150bf20 breaking gles3 Fix typo in shader breaking gles3 May 1, 2024
@akien-mga akien-mga merged commit 02deedc into godotengine:master May 2, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug enhancement regression topic:rendering
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@semensanyok @akien-mga @clayjohn @Rubonnek