Make mouse_focus and mouse_focus_mask consistent for force_drag
#91425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `Viewport::_gui_force_drag` currently `Viewport::gui.mouse_focus` gets cleared, but `Viewport::gui.mouse_focus_mask` doesn't get cleared. This is an inconsistency which can cause a crash. With the change of this PR, `mouse_focus_mask` also gets cleared. This is in alignment with how regular drag and drop clears both variables.
akien-mga
approved these changes
May 2, 2024
akien-mga
added
the
cherrypick:4.2
|
Thanks! |
akien-mga
changed the title
mouse_focus and mouse_focus_mask consistent for force_dragmouse_focus and mouse_focus_mask consistent for force_drag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
Viewport::_gui_force_dragcurrentlyViewport::gui.mouse_focusgets cleared, butViewport::gui.mouse_focus_maskdoesn't get cleared.This is an inconsistency which can cause a crash.
With the change of this PR,
mouse_focus_maskalso gets cleared. This is in alignment with how regular drag and drop clears both variables.resolve #91387