LightmapGI: Fix seam blending with directional lightmaps #90848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarioSamo
approved these changes
Apr 18, 2024
|
@BlueCube3310 Nice catch :) |
akien-mga
added
the
cherrypick:4.2
|
Thanks! |
|
Do you guys take cherry-pick PRs? I think this one should also be added to stable branches, considering how small the code change is. |
The PR already has a cherrypick label, and it should be cherry-pickable without any conflicts already. Therefore, I don't think it's worth opening a dedicated It makes sense to open a dedicated PR when there are conflicts when cherry-picking the commit, but for small code changes (less than 20 lines), this is pretty uncommon between the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90524
The lightmapper used to index into incorrect framebuffers during seam blending, which caused artifacts to appear on lightmaps.