Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid compiler error with RenderingContextDriverVulkanWindows #90326

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Avoid compiler error with RenderingContextDriverVulkanWindows #90326

merged 1 commit into from
Apr 23, 2024

Conversation

fire
Copy link
Member

@fire fire commented Apr 6, 2024

Fixes: #90325

@fire fire marked this pull request as ready for review April 6, 2024 22:53
@fire fire requested a review from a team as a code owner April 6, 2024 22:53
@akien-mga akien-mga added this to the 4.3 milestone Apr 7, 2024
akien-mga
akien-mga approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems consistent with other platforms.

@akien-mga akien-mga merged commit fc912de into godotengine:master Apr 23, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@fire fire deleted the vsk-scons-final-4.3 branch April 23, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug platform:windows topic:buildsystem topic:rendering
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Scons error: class with destructor marked 'final' cannot be inherited from
2 participants
@fire @akien-mga