Add DebugView for Array and Dictionary, based of the DebugView from the .NET Foundation

[warquys]

• Closes C# Debugger display and type proxy  godot-proposals#6969

I am working on reimplementing the debug view for the C# runtime. Initially, I was creating a new debug view. Then, I incorporate the debug view from the .NET Foundation. This approach ensures consistency between the C# runtime’s enumerable and the GODOT enumerable.

This is why the comment of MIT license of the .net Foundation.

[raulsntos]

This looks good to me, thanks.

Not sure what to do about the MIT license header. cc @akien-mga

[akien-mga]

What's the actual source for this DebugView.cs file? The versions I found on Google all only have "All rights reserved." but seem to be older versions.

To be fair, the code is so simple that I'm not even sure this falls under copyright, it's literally just declaring 3 simple classes to fit an interface, and APIs are not copyrightable. Dotnet code includes these two lines of license statement in all files for consistency (like we do), but in this case there isn't much to cover.

C# is verbose but technically it's barely 30 lines of actual code, most of which are actually specific to Godot (using our own implementations of CopyTo for Godot's Array and Dictionary, and KeyValuePair). There's just a few attributes which make it a DebugView implementation, which are described in the docs https://learn.microsoft.com/en-us/dotnet/framework/debug-trace-profile/enhancing-debugging-with-the-debugger-display-attributes and can likely be considered public domain (either way they're part of an interface, not implementation code).

So all in all I don't think that file needs to be encumbered with a specific license/copyright statement, it could be considered Godot code.

[warquys]

The source of this debug view is the .net runtime, debug view is :
ICollectionDebugView.cs, IDictionaryDebugView.cs and DebugViewDictionaryItem.cs.

[warquys]

I force pushed to divide the commit in two and change the indentation.
In this way if it is considered that the license does not apply I would just remove the last commit.

[akien-mga]

Thanks for the links!

I think this is trivial enough to not require attribution, so I think we can drop the second commit.

[warquys]

Ok, i drop it

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉