Expose bindings to compute dispatch indirect of rendering device #89491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thimenesup
force-pushed
the
compute_dispatch_indirect
branch
from
5b3e75b
to
8017c8c
Compare
|
Would like to clarify that it works as expected, also added docs to it, which may be the reason why this hasn't been merged after a month but I am not a clairvoyant. |
RandomShaper
approved these changes
Apr 8, 2024
clayjohn
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Would like to clarify that it works as expected, also added docs to it, which may be the reason why this hasn't been merged after a month but I am not a clairvoyant.
Sorry for the lack of comment. Most of us who regularly review PRs were away for most of the last month and we have not caught up on the PR backlog. You are not being ignored intentionally
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title is self explanatory, unsure why this wasn't done at the time it was implemented.