Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Vector* component-wise min/max/clamp functions where applicable #89111

Merged
1 commit merged into from
Mar 24, 2024
Merged

Use Vector* component-wise min/max/clamp functions where applicable #89111

1 commit merged into from
Mar 24, 2024

Conversation

AThousandShips
Copy link
Member

Improves readability and safety, separated off the clamp changes as they might be less clear

@AThousandShips AThousandShips added this to the 4.x milestone Mar 3, 2024
@AThousandShips AThousandShips requested review from a team as code owners March 3, 2024 11:52
@AThousandShips AThousandShips mentioned this pull request Mar 3, 2024
Merged
@AThousandShips AThousandShips changed the title [Core] Use Vector* component-wise min/max/clamp functions where applicable Use Vector* component-wise min/max/clamp functions where applicable Mar 3, 2024
@AThousandShips AThousandShips requested review from a team as code owners March 3, 2024 13:05
Geometror
Geometror approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@Geometror Geometror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through each replacement and didn't notice any obvious mistake.
Nice work!

@AThousandShips
Copy link
Member Author

AThousandShips commented Mar 20, 2024 •
edited
Loading

Thank you! Squashed and ready

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Mar 23, 2024
akien-mga added a commit that referenced this pull request Mar 24, 2024
@akien-mga
Merge pull request #89111 from AThousandShips/vec_use
cd4e4c0 
Use `Vector*` component-wise `min/max/clamp` functions where applicable
@akien-mga akien-mga closed this pull request by merging all changes into godotengine:master in 06abc86 Mar 24, 2024
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the vec_use branch March 24, 2024 08:45
@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruvzg bruvzg bruvzg left review comments

@Geometror Geometror Geometror approved these changes

Assignees
No one assigned
Labels
enhancement topic:codestyle
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@AThousandShips @akien-mga @bruvzg @Geometror