Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix C# epsilon compiler error on double precision build #88994

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Fix C# epsilon compiler error on double precision build #88994

merged 1 commit into from
Feb 29, 2024

Conversation

TCROC
Copy link
Contributor

@TCROC TCROC commented Feb 29, 2024 •
edited by akien-mga
Loading

Currently 64 bit C# builds of Godot are failing due to a compiler error. This fixes #88993

It appears the 64 bit / long version of Epsilon was missed in a recent refactor.

@TCROC TCROC requested a review from a team as a code owner February 29, 2024 00:15
@TCROC TCROC changed the title Fixed 64 bit C# Epsilon Fixed 64 bit C# Epsilon Compiler Error Feb 29, 2024
@raulsntos raulsntos added this to the 4.3 milestone Feb 29, 2024
raulsntos
raulsntos approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks for the fix!

@raulsntos raulsntos linked an issue Feb 29, 2024 that may be closed by this pull request
C# precision=double compiler error - wrong epsilon variable #88993
Closed
@TCROC
Copy link
Contributor Author

TCROC commented Feb 29, 2024

No problem! :) do we have any CI / pipelines / automation for checking C# 64 bit compilations? If not, I'd be happy to add it :)

@TCROC
Copy link
Contributor Author

TCROC commented Feb 29, 2024

Above question is being discussed over here: #88993 (comment)

@akien-mga akien-mga changed the title Fixed 64 bit C# Epsilon Compiler Error Fix C# epsilon compiler error on double precision build Feb 29, 2024
@paulloz
Copy link
Member

paulloz commented Feb 29, 2024

I knew I would've broken something 🥲
Thanks for catching the issue.

@akien-mga
Copy link
Member

Could you amend the commit message to be more explicit? E.g. the edit I did to this PR's title should be a good option:

Fix C# epsilon compiler error on double precision build

@TCROC
Copy link
Contributor Author

TCROC commented Feb 29, 2024

Yep. Just woke up. Gonna get myself some coffee then will amend it :)

@TCROC TCROC force-pushed the fix-c#-missing-epsilon-64bit branch from 7eb235d to 09c6cb1 Compare February 29, 2024 13:25
@TCROC
Copy link
Contributor Author

TCROC commented Feb 29, 2024

Renamed the commit message per @akien-mga 's suggestion. Let me know if you need anything else :)

@akien-mga akien-mga merged commit b0c184c into godotengine:master Feb 29, 2024
16 checks passed
@akien-mga
Copy link
Member

akien-mga commented Feb 29, 2024 •
edited
Loading

Thanks! And congrats for your first merged Godot contribution 🎉

@TCROC
Copy link
Contributor Author

TCROC commented Feb 29, 2024

Thanks you as well! ♥️ I've put in a few PRs, but feels good to have the first go in with my name! Albeit a small one, but yay! :) Gonna celebrate tonight 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulsntos raulsntos raulsntos approved these changes

Assignees
No one assigned
Labels
bug topic:dotnet
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

C# precision=double compiler error - wrong epsilon variable
4 participants
@TCROC @paulloz @akien-mga @raulsntos