Revise implementation of C# Aabb.GetSupport to match the implementation in core

[nongvantinh]

fixes: #88834

[paulloz]

We'd be interested in opinions from core contributors here, since we're not entirely sure about the implications.
The C++ implementation changed in #44468, and was not ported to C# before the current PR.

[nongvantinh]

I think he might have forgotten to update the C# module because he's too busy. Besides, what benefits could this diversity bring?

[paulloz]

I think he might have forgotten to update the C# module because he's too busy. Besides, what benefits could this diversity bring?

This isn't really the question. We (referring to @raulsntos and I) are simply trying to establish which is less harmful between:

• Keeping the current behaviour.
• Introducing the change, and potentially breaking people's code currently relying on this behaviour.

In essence: pushing aside the difference with GDScript, does the returned value even make sense? Hence, the review from another team, more aware of the implications.

[raulsntos]

What we got from the rendering team on RC is that the current GetSupport implementation returns the opposite of the support, and this PR fixes that. We also think that it's unlikely there are many users consuming this API, so we think breaking compat here is acceptable. Let's merge this for the 4.3 beta, and see if we get user reports.

[akien-mga]

Thanks!